chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm - Issue 2335623002: Use WebContents instead of Browser to construct PermissionPrompt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

Issue 2335623002: Use WebContents instead of Browser to construct PermissionPrompt (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_request_manager.cc ('K') | « chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h ('k') | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm » ('j') | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

index 61bd246166717a1e644ef40c9ad7ad491b978620..9db443ad0edfb1627146d30f51e893e8a88cd6d0 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

@@ -5,15 +5,18 @@

#include "chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h"

#include "base/memory/ptr_util.h"

+#import "chrome/browser/ui/browser_finder.h"

#import "chrome/browser/ui/cocoa/base_bubble_controller.h"

#import "chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h"

#import "chrome/browser/ui/website_settings/permission_prompt.h"

#include "content/public/browser/web_contents.h"

#import "ui/base/cocoa/nsview_additions.h"

-PermissionBubbleCocoa::PermissionBubbleCocoa(Browser* browser)

- : browser_(browser), delegate_(nullptr), bubbleController_(nil) {

- DCHECK(browser);

+PermissionBubbleCocoa::PermissionBubbleCocoa(content::WebContents* web_contents)

+ : browser_(chrome::FindBrowserWithWebContents(web_contents)),

+ delegate_(nullptr),

+ bubbleController_(nil) {

+ DCHECK(browser_);

}

PermissionBubbleCocoa::~PermissionBubbleCocoa() {