chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h - Issue 2335623002: Use WebContents instead of Browser to construct PermissionPrompt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

Issue 2335623002: Use WebContents instead of Browser to construct PermissionPrompt (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_request_manager.cc ('K') | « chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm ('k') | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm » ('j') | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

index c9a2a58c32caa66f9a5ffe6c95882f9fe5d07ab5..875da63149b736cb14266bcd33ac7a4d922b662a 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

@@ -5,6 +5,7 @@

#import <Cocoa/Cocoa.h>

#include "base/mac/scoped_nsobject.h"

+#include "chrome/browser/ui/browser.h"

raymes 2016/09/15 02:06:46 nit: I think we can forward declare this rather th

lshang 2016/09/15 09:45:06 Done.

#import "chrome/browser/ui/cocoa/base_bubble_controller.h"

#include "chrome/browser/ui/website_settings/permission_prompt.h"

#include "ui/base/models/simple_menu_model.h"