Description was changed from ========== Reland of "[telemetry] Wire TsProxy through telemetry's network stack." (patchset ...
4 years, 3 months ago
(2016-09-14 15:25:48 UTC)
#4
Message was sent while issue was closed.
Description was changed from
==========
Reland of "[telemetry] Wire TsProxy through telemetry's network stack."
(patchset #1 id:1 of https://codereview.chromium.org/2342503002/ )
Reason for revert:
Broke WPR replay on WebView bots
Original issue's description:
> Revert of Revert "[telemetry] Wire TsProxy through telemetry's network stack."
(patchset #1 id:1 of https://codereview.chromium.org/2267613002/ )
>
> Reason for revert:
> Webview now support --proxy-server flag (see attached bug)
>
> Original issue's description:
> > Revert "[telemetry] Wire TsProxy through telemetry's network stack."
> >
> > This reverts commit 9fcccf0b65703994c9541273f00a993806a95356.
> >
> > Revert "[Telemetry] Explictly initialize & clean up network_controller"
> >
> > This reverts commit 30ce231266c6fb6147bb6df7c56a7eb75c23fccf.
> >
> > Seems like webview currently does not support proxy server?
> > (See attached chromium bug)
> >
> > BUG=chromium:639632
> > BUG=catapult:#2584
> >
> > TBR=pmeenan@chromium.org
> >
> > Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
>
> TBR=nednguyen@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=chromium:639632
>
> Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...TBR=nednguyen@chromium.org,nednguyen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:639632
==========
to
==========
Reland of "[telemetry] Wire TsProxy through telemetry's network stack."
(patchset #1 id:1 of https://codereview.chromium.org/2342503002/ )
Reason for revert:
Broke WPR replay on WebView bots
Original issue's description:
> Revert of Revert "[telemetry] Wire TsProxy through telemetry's network stack."
(patchset #1 id:1 of https://codereview.chromium.org/2267613002/ )
>
> Reason for revert:
> Webview now support --proxy-server flag (see attached bug)
>
> Original issue's description:
> > Revert "[telemetry] Wire TsProxy through telemetry's network stack."
> >
> > This reverts commit 9fcccf0b65703994c9541273f00a993806a95356.
> >
> > Revert "[Telemetry] Explictly initialize & clean up network_controller"
> >
> > This reverts commit 30ce231266c6fb6147bb6df7c56a7eb75c23fccf.
> >
> > Seems like webview currently does not support proxy server?
> > (See attached chromium bug)
> >
> > BUG=chromium:639632
> > BUG=catapult:#2584
> >
> > TBR=pmeenan@chromium.org
> >
> > Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
>
> TBR=nednguyen@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=chromium:639632
>
> Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...TBR=nednguyen@chromium.org,nednguyen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:639632
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/32dd31095913725705e9cf5f5bc1671f32821a35
4 years, 3 months ago
(2016-09-14 15:25:49 UTC)
#5
Issue 2335403003: Reland of "[telemetry] Wire TsProxy through telemetry's network stack."
(Closed)
Created 4 years, 3 months ago by perezju
Modified 4 years, 3 months ago
Reviewers: nednguyen(REVIEW IN OTHER ACC), nednguyen
Base URL: https://github.com/catapult-project/catapult.git@master
Comments: 0