telemetry/telemetry/testing/browser_test_case.py - Issue 2335403003: Reland of "[telemetry] Wire TsProxy through telemetry's network stack."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/testing/browser_test_case.py

Issue 2335403003: Reland of "[telemetry] Wire TsProxy through telemetry's network stack." (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: telemetry/telemetry/testing/browser_test_case.py

diff --git a/telemetry/telemetry/testing/browser_test_case.py b/telemetry/telemetry/testing/browser_test_case.py

index 956e5d85e8a8b8994fabde0f699e0658f50f3522..9eff8eec1f4716dd7f78fab44a6a19d6b5718f96 100644

--- a/telemetry/telemetry/testing/browser_test_case.py

+++ b/telemetry/telemetry/testing/browser_test_case.py

@@ -85,8 +85,6 @@

browser_to_create = browser_finder.FindBrowser(options)

if not browser_to_create:

raise Exception('No browser found, cannot continue test.')

- cls._platform = browser_to_create.platform

- cls._platform.network_controller.InitializeIfNeeded()

try:

current_browser = browser_to_create.Create(options)

@@ -95,13 +93,13 @@

cls.tearDownClass()

raise

cls._browser = current_browser

+ cls._platform = current_browser.platform

cls._device = options.remote_platform_options.device

@classmethod

def tearDownClass(cls):

if cls._platform:

cls._platform.StopAllLocalServers()

- cls._platform.network_controller.Close()

@classmethod

def CustomizeBrowserOptions(cls, options):

« no previous file with comments | « telemetry/telemetry/page/shared_page_state.py ('k') | telemetry/telemetry/testing/fakes/__init__.py » ('j') | no next file with comments »