telemetry/telemetry/internal/util/wpr_server.py - Issue 2335403003: Reland of "[telemetry] Wire TsProxy through telemetry's network stack."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/util/wpr_server.py

Issue 2335403003: Reland of "[telemetry] Wire TsProxy through telemetry's network stack." (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/util/ts_proxy_server_unittest.py ('k') | telemetry/telemetry/page/shared_page_state.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/util/wpr_server.py

diff --git a/telemetry/telemetry/internal/util/wpr_server.py b/telemetry/telemetry/internal/util/wpr_server.py

index 9530d3acb3a6e358484861c6fa7e2542f38b2ef1..37bad8f0f190c7c614ef2627412fd193a20bc92d 100644

--- a/telemetry/telemetry/internal/util/wpr_server.py

+++ b/telemetry/telemetry/internal/util/wpr_server.py

@@ -199,7 +199,7 @@

is_posix = sys.platform.startswith('linux') or sys.platform == 'darwin'

logging.info('Starting Web-Page-Replay: %s', self._cmd_line)

self._CreateTempLogFilePath()

- with open(self._temp_log_file_path, 'w') as log_fh:

+ with self._OpenLogFile() as log_fh:

self.replay_process = subprocess.Popen(

self._cmd_line, stdout=log_fh, stderr=subprocess.STDOUT,

preexec_fn=(_ResetInterruptHandler if is_posix else None))

« no previous file with comments | « telemetry/telemetry/internal/util/ts_proxy_server_unittest.py ('k') | telemetry/telemetry/page/shared_page_state.py » ('j') | no next file with comments »