Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2359933002: Use sk_careful_memcpy when writing optional conic weights for GrShape path data key. (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use sk_careful_memcpy when writing optional conic weights for GrShape path data key. TBR=robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2359933002 NO_DEPENDENCY_CHECKS=true Committed: https://skia.googlesource.com/skia/+/0e4a466a613fa02292dfdbd8d4097fc14f191c42

Patch Set 1 #

Patch Set 2 : remove dependency #

Patch Set 3 : actually remove dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/gpu/GrShape.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (13 generated)
commit-bot: I haz the power
This CL has an open dependency (Issue 2335343008 Patch 180001). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-21 17:47:41 UTC) #4
mtklein_C
(lgtm)
4 years, 3 months ago (2016-09-21 17:51:24 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2335343008 Patch 180001). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-21 18:00:53 UTC) #10
commit-bot: I haz the power
This CL has an open dependency (Issue 2335343008 Patch 180001). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-21 18:06:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359933002/40001
4 years, 3 months ago (2016-09-21 18:07:42 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 18:23:49 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0e4a466a613fa02292dfdbd8d4097fc14f191c42

Powered by Google App Engine
This is Rietveld 408576698