Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2335283002: Removes QUIC flag and code that shifts cubic epoch on quiescence, since it's buggy and should not b… (Closed)

Created:
4 years, 3 months ago by Jana
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes QUIC flag and code that shifts cubic epoch on quiescence, since it's buggy and should not be used. R=rch@chromium.org BUG= Committed: https://crrev.com/8612f515cbf768a6ae96d5c13573b3fb79282bb0 Cr-Commit-Position: refs/heads/master@{#418460}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -69 lines) Patch
M net/quic/core/congestion_control/cubic.cc View 2 chunks +3 lines, -23 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
Jana
4 years, 3 months ago (2016-09-13 16:57:56 UTC) #1
Ryan Hamilton
Are you planning to merge this to M54, or are you simply going to disable ...
4 years, 3 months ago (2016-09-13 17:21:18 UTC) #2
Ryan Hamilton
On 2016/09/13 17:21:18, Ryan Hamilton wrote: > Are you planning to merge this to M54, ...
4 years, 3 months ago (2016-09-13 21:32:48 UTC) #3
Ryan Hamilton
lgtm
4 years, 3 months ago (2016-09-13 21:32:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335283002/20001
4 years, 3 months ago (2016-09-14 00:29:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 02:41:54 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 02:43:37 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8612f515cbf768a6ae96d5c13573b3fb79282bb0
Cr-Commit-Position: refs/heads/master@{#418460}

Powered by Google App Engine
This is Rietveld 408576698