Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: net/quic/core/quic_flags_list.h

Issue 2335283002: Removes QUIC flag and code that shifts cubic epoch on quiescence, since it's buggy and should not b… (Closed)
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file intentionally does not have header guards, it's included 5 // This file intentionally does not have header guards, it's included
6 // inside a macro to generate values. 6 // inside a macro to generate values.
7 7
8 // This file contains the list of QUIC protocol flags. 8 // This file contains the list of QUIC protocol flags.
9 9
10 // If true, it will return as soon as an error is detected while validating 10 // If true, it will return as soon as an error is detected while validating
(...skipping 26 matching lines...) Expand all
37 QUIC_FLAG(bool, FLAGS_quic_always_log_bugs_for_tests, true) 37 QUIC_FLAG(bool, FLAGS_quic_always_log_bugs_for_tests, true)
38 38
39 // If true, multipath is enabled for the connection. 39 // If true, multipath is enabled for the connection.
40 QUIC_FLAG(bool, FLAGS_quic_enable_multipath, false) 40 QUIC_FLAG(bool, FLAGS_quic_enable_multipath, false)
41 41
42 // If true, require handshake confirmation for QUIC connections, functionally 42 // If true, require handshake confirmation for QUIC connections, functionally
43 // disabling 0-rtt handshakes. 43 // disabling 0-rtt handshakes.
44 // TODO(rtenneti): Enable this flag after CryptoServerTest's are fixed. 44 // TODO(rtenneti): Enable this flag after CryptoServerTest's are fixed.
45 QUIC_FLAG(bool, FLAGS_quic_require_handshake_confirmation, false) 45 QUIC_FLAG(bool, FLAGS_quic_require_handshake_confirmation, false)
46 46
47 // If true, Cubic's epoch is shifted when the sender is application-limited.
48 QUIC_FLAG(bool, FLAGS_shift_quic_cubic_epoch_when_app_limited, false)
49
50 // If true, QUIC will measure head of line (HOL) blocking due between 47 // If true, QUIC will measure head of line (HOL) blocking due between
51 // streams due to packet losses on the headers stream. The 48 // streams due to packet losses on the headers stream. The
52 // measurements will be surfaced via UMA histogram 49 // measurements will be surfaced via UMA histogram
53 // Net.QuicSession.HeadersHOLBlockedTime. 50 // Net.QuicSession.HeadersHOLBlockedTime.
54 QUIC_FLAG(bool, FLAGS_quic_measure_headers_hol_blocking_time, true) 51 QUIC_FLAG(bool, FLAGS_quic_measure_headers_hol_blocking_time, true)
55 52
56 // If true, disable pacing in QUIC. 53 // If true, disable pacing in QUIC.
57 QUIC_FLAG(bool, FLAGS_quic_disable_pacing_for_perf_tests, false) 54 QUIC_FLAG(bool, FLAGS_quic_disable_pacing_for_perf_tests, false)
58 55
59 // If true, Close the connection instead of writing unencrypted stream data. 56 // If true, Close the connection instead of writing unencrypted stream data.
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 // rest to next event. This flag can be turned on only if 170 // rest to next event. This flag can be turned on only if
174 // --quic_buffer_packet_till_chlo is true. 171 // --quic_buffer_packet_till_chlo is true.
175 QUIC_FLAG(bool, FLAGS_quic_limit_num_new_sessions_per_epoll_loop, true) 172 QUIC_FLAG(bool, FLAGS_quic_limit_num_new_sessions_per_epoll_loop, true)
176 173
177 // If true, lazy allocate and early release memeory used in 174 // If true, lazy allocate and early release memeory used in
178 // QuicStreamSequencerBuffer to buffer incoming data. 175 // QuicStreamSequencerBuffer to buffer incoming data.
179 QUIC_FLAG(bool, FLAGS_quic_reduce_sequencer_buffer_memory_life_time, true) 176 QUIC_FLAG(bool, FLAGS_quic_reduce_sequencer_buffer_memory_life_time, true)
180 177
181 // If true, allow server address change if it is because of mapped ipv4 address. 178 // If true, allow server address change if it is because of mapped ipv4 address.
182 QUIC_FLAG(bool, FLAGS_quic_allow_server_address_change_for_mapped_ipv4, true) 179 QUIC_FLAG(bool, FLAGS_quic_allow_server_address_change_for_mapped_ipv4, true)
OLDNEW
« no previous file with comments | « net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698