Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc

Issue 2335283002: Removes QUIC flag and code that shifts cubic epoch on quiescence, since it's buggy and should not b… (Closed)
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/congestion_control/cubic.cc ('k') | net/quic/core/quic_flags_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc
diff --git a/net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc b/net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc
index 91bcea238cd6df23ccc521c8a3543ac8ad1e7c8d..2e3d54479d6e492addd0db2bb0e0a1f7900e22ff 100644
--- a/net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc
+++ b/net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc
@@ -644,49 +644,6 @@ TEST_F(TcpCubicSenderPacketsTest, TcpCubicResetEpochOnQuiescence) {
EXPECT_GT(kMaxCongestionWindowBytes, sender_->GetCongestionWindow());
}
-TEST_F(TcpCubicSenderPacketsTest, TcpCubicShiftedEpochOnQuiescence) {
- FLAGS_shift_quic_cubic_epoch_when_app_limited = true;
- const int kMaxCongestionWindow = 50;
- const QuicByteCount kMaxCongestionWindowBytes =
- kMaxCongestionWindow * kDefaultTCPMSS;
- sender_.reset(
- new TcpCubicSenderPacketsPeer(&clock_, false, kMaxCongestionWindow));
-
- int num_sent = SendAvailableSendWindow();
-
- // Make sure we fall out of slow start.
- QuicByteCount saved_cwnd = sender_->GetCongestionWindow();
- LoseNPackets(1);
- EXPECT_GT(saved_cwnd, sender_->GetCongestionWindow());
-
- // Ack the rest of the outstanding packets to get out of recovery.
- for (int i = 1; i < num_sent; ++i) {
- AckNPackets(1);
- }
- EXPECT_EQ(0u, bytes_in_flight_);
-
- // Send a new window of data and ack all; cubic growth should occur.
- saved_cwnd = sender_->GetCongestionWindow();
- num_sent = SendAvailableSendWindow();
- for (int i = 0; i < num_sent; ++i) {
- AckNPackets(1);
- }
- EXPECT_LT(saved_cwnd, sender_->GetCongestionWindow());
- EXPECT_GT(kMaxCongestionWindowBytes, sender_->GetCongestionWindow());
- EXPECT_EQ(0u, bytes_in_flight_);
-
- // Quiescent time of 100 seconds
- clock_.AdvanceTime(QuicTime::Delta::FromSeconds(100));
-
- // Send new window of data and ack one packet. Cubic epoch should have
- // been reset; ensure cwnd increase is not dramatic.
- saved_cwnd = sender_->GetCongestionWindow();
- SendAvailableSendWindow();
- AckNPackets(1);
- EXPECT_NEAR(saved_cwnd, sender_->GetCongestionWindow(), kDefaultTCPMSS);
- EXPECT_GT(kMaxCongestionWindowBytes, sender_->GetCongestionWindow());
-}
-
TEST_F(TcpCubicSenderPacketsTest, MultipleLossesInOneWindow) {
SendAvailableSendWindow();
const QuicByteCount initial_window = sender_->GetCongestionWindow();
« no previous file with comments | « net/quic/core/congestion_control/cubic.cc ('k') | net/quic/core/quic_flags_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698