Make SharedGpuContext recover automatically after a context loss

Make SharedGpuContext recover automatically after a context loss

The lack of gpu context recovery was causing some layout tests
to be flaky. After running the test
virtual/gpu/fast/canvas/canvas-lost-gpu-context.html all subsequent
gpu tests run in the same instance of content_shell would fail.

BUG=646973
Committed: https://crrev.com/bb27517d08d74205ceaddc98cfae311916883d09
Cr-Commit-Position: refs/heads/master@{#418998}

[Justin Novosad, 2016-09-14 20:43:21]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[Justin Novosad, 2016-09-14 20:43:41]

junov@chromium.org changed reviewers:
+ xidachen@chromium.org

[Justin Novosad, 2016-09-14 20:43:42]

PTAL

[commit-bot: I haz the power, 2016-09-14 20:44:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 21:10:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 21:10:37]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Justin Novosad, 2016-09-15 17:54:20]

New patch.  This one fixes flake for realz.

[Justin Novosad, 2016-09-15 18:03:26]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 18:04:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 18:30:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 18:30:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xidachen, 2016-09-15 18:53:35]

https://codereview.chromium.org/2335223004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.h (right):

https://codereview.chromium.org/2335223004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.h:21: class
SharedGpuContext {
I think you need to add PLATFORM_EXPORT in here, otherwise the unit test cannot
refer to this class.

https://codereview.chromium.org/2335223004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.h:31: static
bool isValidWithoutRestoring();
Is this method suppose to be called inside unit-tests only? If that's the case,
a comment describing it would be great.

[danakj, 2016-09-15 19:00:58]

https://codereview.chromium.org/2335223004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.h (right):

https://codereview.chromium.org/2335223004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.h:31: static
bool isValidWithoutRestoring();
On 2016/09/15 18:53:35, xidachen wrote:
> Is this method suppose to be called inside unit-tests only? If that's the
case,
> a comment describing it would be great.

(or ForTesting suffix will enforce that).

[Justin Novosad, 2016-09-15 20:33:02]

On 2016/09/15 18:53:35, xidachen wrote:

>
https://codereview.chromium.org/2335223004/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.h:31: static
> bool isValidWithoutRestoring();
> Is this method suppose to be called inside unit-tests only? If that's the
case,
> a comment describing it would be great.

Right now it is only used in a unit test, but there is no danger in this method
getting called outside of tests, and I don't think we need to suggest that.

[Justin Novosad, 2016-09-15 20:35:43]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[Justin Novosad, 2016-09-15 20:35:57]

new patch

[commit-bot: I haz the power, 2016-09-15 20:36:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xidachen, 2016-09-15 20:37:09]

On 2016/09/15 20:35:57, Justin Novosad wrote:
> new patch

lgtm

[Justin Novosad, 2016-09-15 20:39:38]

The CQ bit was unchecked by junov@chromium.org

[Justin Novosad, 2016-09-15 20:39:44]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2016-09-15 20:40:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 21:59:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-15 22:02:56]

Description was changed from

==========
Make SharedGpuContext recover automatically after a context loss

The lack of gpu context recovery was causing some layout tests
to be flaky. After running the test
virtual/gpu/fast/canvas/canvas-lost-gpu-context.html all subsequent
gpu tests run in the same instance of content_shell would fail.

BUG=646973
==========

to

==========
Make SharedGpuContext recover automatically after a context loss

The lack of gpu context recovery was causing some layout tests
to be flaky. After running the test
virtual/gpu/fast/canvas/canvas-lost-gpu-context.html all subsequent
gpu tests run in the same instance of content_shell would fail.

BUG=646973

Committed: https://crrev.com/bb27517d08d74205ceaddc98cfae311916883d09
Cr-Commit-Position: refs/heads/master@{#418998}
==========

[commit-bot: I haz the power, 2016-09-15 22:02:57]

Patchset 4 (id:??) landed as
https://crrev.com/bb27517d08d74205ceaddc98cfae311916883d09
Cr-Commit-Position: refs/heads/master@{#418998}