Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2335153002: Use TestSimpleTaskRunner::NumPendingTasks instead of GetPendingTasks().size() (Closed)

Created:
4 years, 3 months ago by tzik
Modified:
4 years, 3 months ago
CC:
awdf+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, mlamouri+watch-notifications_chromium.org, Peter Beverloo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TestSimpleTaskRunner::NumPendingTasks instead of GetPendingTasks().size() TestSimpleTaskRunner::GetPendingTasks returns a full copy of the queued pending tasks, which is less clean, and also that prevents a refactoring that makes tasks move-only. This CL replaces them with an equivalent NumPendingTasks to avoid the copy. BUG=554299 Committed: https://crrev.com/bdac06c0a9913c5bc245d9e4b900b6af826e503f Cr-Commit-Position: refs/heads/master@{#418496}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M base/task/cancelable_task_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/extension_welcome_notification_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/one_shot_event_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
tzik
PTAL
4 years, 3 months ago (2016-09-13 08:41:20 UTC) #7
stevenjb
lgtm
4 years, 3 months ago (2016-09-13 16:03:20 UTC) #16
Ken Rockot(use gerrit already)
lgtm
4 years, 3 months ago (2016-09-13 16:04:49 UTC) #17
dcheng
lgtm
4 years, 3 months ago (2016-09-13 16:07:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2335153002/100001
4 years, 3 months ago (2016-09-14 05:08:20 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 3 months ago (2016-09-14 05:55:03 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 05:57:01 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/bdac06c0a9913c5bc245d9e4b900b6af826e503f
Cr-Commit-Position: refs/heads/master@{#418496}

Powered by Google App Engine
This is Rietveld 408576698