Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: extensions/common/one_shot_event_unittest.cc

Issue 2335153002: Use TestSimpleTaskRunner::NumPendingTasks instead of GetPendingTasks().size() (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/notifications/extension_welcome_notification_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/one_shot_event_unittest.cc
diff --git a/extensions/common/one_shot_event_unittest.cc b/extensions/common/one_shot_event_unittest.cc
index c19b036609e8f27b2df72977b84f5f49ce0ee960..db0bca9fc8846c62f84b6a6b2c85d21b15cffc95 100644
--- a/extensions/common/one_shot_event_unittest.cc
+++ b/extensions/common/one_shot_event_unittest.cc
@@ -30,9 +30,9 @@ TEST(OneShotEventTest, CallsQueue) {
int i = 0;
event.Post(FROM_HERE, base::Bind(&Increment, &i), runner);
event.Post(FROM_HERE, base::Bind(&Increment, &i), runner);
- EXPECT_EQ(0U, runner->GetPendingTasks().size());
+ EXPECT_EQ(0U, runner->NumPendingTasks());
event.Signal();
- ASSERT_EQ(2U, runner->GetPendingTasks().size());
+ ASSERT_EQ(2U, runner->NumPendingTasks());
EXPECT_NE(runner->GetPendingTasks()[0].location.line_number(),
runner->GetPendingTasks()[1].location.line_number())
<< "Make sure FROM_HERE is propagated.";
@@ -49,7 +49,7 @@ TEST(OneShotEventTest, CallsAfterSignalDontRunInline) {
event.Signal();
event.Post(FROM_HERE, base::Bind(&Increment, &i), runner);
- EXPECT_EQ(1U, runner->GetPendingTasks().size());
+ EXPECT_EQ(1U, runner->NumPendingTasks());
EXPECT_EQ(0, i);
runner->RunPendingTasks();
EXPECT_EQ(1, i);
@@ -66,7 +66,7 @@ TEST(OneShotEventTest, PostDefaultsToCurrentMessageLoop) {
event.Post(FROM_HERE, base::Bind(&Increment, &runner_i), runner);
event.Post(FROM_HERE, base::Bind(&Increment, &loop_i));
event.Signal();
- EXPECT_EQ(1U, runner->GetPendingTasks().size());
+ EXPECT_EQ(1U, runner->NumPendingTasks());
EXPECT_EQ(0, runner_i);
runner->RunPendingTasks();
EXPECT_EQ(1, runner_i);
@@ -96,15 +96,15 @@ TEST(OneShotEventTest, IsSignaledAndPostsFromCallbackWork) {
event.Signal();
// CheckSignaledAndPostIncrement is queued on |runner|.
- EXPECT_EQ(1U, runner->GetPendingTasks().size());
+ EXPECT_EQ(1U, runner->NumPendingTasks());
EXPECT_EQ(0, i);
runner->RunPendingTasks();
// Increment is queued on |runner|.
- EXPECT_EQ(1U, runner->GetPendingTasks().size());
+ EXPECT_EQ(1U, runner->NumPendingTasks());
EXPECT_EQ(0, i);
runner->RunPendingTasks();
// Increment has run.
- EXPECT_EQ(0U, runner->GetPendingTasks().size());
+ EXPECT_EQ(0U, runner->NumPendingTasks());
EXPECT_EQ(1, i);
}
« no previous file with comments | « chrome/browser/notifications/extension_welcome_notification_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698