Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Side by Side Diff: extensions/common/one_shot_event_unittest.cc

Issue 2335153002: Use TestSimpleTaskRunner::NumPendingTasks instead of GetPendingTasks().size() (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/notifications/extension_welcome_notification_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/one_shot_event.h" 5 #include "extensions/common/one_shot_event.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/run_loop.h" 8 #include "base/run_loop.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "base/test/test_simple_task_runner.h" 10 #include "base/test/test_simple_task_runner.h"
(...skipping 12 matching lines...) Expand all
23 EXPECT_TRUE(event.is_signaled()); 23 EXPECT_TRUE(event.is_signaled());
24 } 24 }
25 25
26 TEST(OneShotEventTest, CallsQueue) { 26 TEST(OneShotEventTest, CallsQueue) {
27 OneShotEvent event; 27 OneShotEvent event;
28 scoped_refptr<base::TestSimpleTaskRunner> runner( 28 scoped_refptr<base::TestSimpleTaskRunner> runner(
29 new base::TestSimpleTaskRunner); 29 new base::TestSimpleTaskRunner);
30 int i = 0; 30 int i = 0;
31 event.Post(FROM_HERE, base::Bind(&Increment, &i), runner); 31 event.Post(FROM_HERE, base::Bind(&Increment, &i), runner);
32 event.Post(FROM_HERE, base::Bind(&Increment, &i), runner); 32 event.Post(FROM_HERE, base::Bind(&Increment, &i), runner);
33 EXPECT_EQ(0U, runner->GetPendingTasks().size()); 33 EXPECT_EQ(0U, runner->NumPendingTasks());
34 event.Signal(); 34 event.Signal();
35 ASSERT_EQ(2U, runner->GetPendingTasks().size()); 35 ASSERT_EQ(2U, runner->NumPendingTasks());
36 EXPECT_NE(runner->GetPendingTasks()[0].location.line_number(), 36 EXPECT_NE(runner->GetPendingTasks()[0].location.line_number(),
37 runner->GetPendingTasks()[1].location.line_number()) 37 runner->GetPendingTasks()[1].location.line_number())
38 << "Make sure FROM_HERE is propagated."; 38 << "Make sure FROM_HERE is propagated.";
39 EXPECT_EQ(0, i); 39 EXPECT_EQ(0, i);
40 runner->RunPendingTasks(); 40 runner->RunPendingTasks();
41 EXPECT_EQ(2, i); 41 EXPECT_EQ(2, i);
42 } 42 }
43 43
44 TEST(OneShotEventTest, CallsAfterSignalDontRunInline) { 44 TEST(OneShotEventTest, CallsAfterSignalDontRunInline) {
45 OneShotEvent event; 45 OneShotEvent event;
46 scoped_refptr<base::TestSimpleTaskRunner> runner( 46 scoped_refptr<base::TestSimpleTaskRunner> runner(
47 new base::TestSimpleTaskRunner); 47 new base::TestSimpleTaskRunner);
48 int i = 0; 48 int i = 0;
49 49
50 event.Signal(); 50 event.Signal();
51 event.Post(FROM_HERE, base::Bind(&Increment, &i), runner); 51 event.Post(FROM_HERE, base::Bind(&Increment, &i), runner);
52 EXPECT_EQ(1U, runner->GetPendingTasks().size()); 52 EXPECT_EQ(1U, runner->NumPendingTasks());
53 EXPECT_EQ(0, i); 53 EXPECT_EQ(0, i);
54 runner->RunPendingTasks(); 54 runner->RunPendingTasks();
55 EXPECT_EQ(1, i); 55 EXPECT_EQ(1, i);
56 } 56 }
57 57
58 TEST(OneShotEventTest, PostDefaultsToCurrentMessageLoop) { 58 TEST(OneShotEventTest, PostDefaultsToCurrentMessageLoop) {
59 OneShotEvent event; 59 OneShotEvent event;
60 scoped_refptr<base::TestSimpleTaskRunner> runner( 60 scoped_refptr<base::TestSimpleTaskRunner> runner(
61 new base::TestSimpleTaskRunner); 61 new base::TestSimpleTaskRunner);
62 base::MessageLoop loop; 62 base::MessageLoop loop;
63 int runner_i = 0; 63 int runner_i = 0;
64 int loop_i = 0; 64 int loop_i = 0;
65 65
66 event.Post(FROM_HERE, base::Bind(&Increment, &runner_i), runner); 66 event.Post(FROM_HERE, base::Bind(&Increment, &runner_i), runner);
67 event.Post(FROM_HERE, base::Bind(&Increment, &loop_i)); 67 event.Post(FROM_HERE, base::Bind(&Increment, &loop_i));
68 event.Signal(); 68 event.Signal();
69 EXPECT_EQ(1U, runner->GetPendingTasks().size()); 69 EXPECT_EQ(1U, runner->NumPendingTasks());
70 EXPECT_EQ(0, runner_i); 70 EXPECT_EQ(0, runner_i);
71 runner->RunPendingTasks(); 71 runner->RunPendingTasks();
72 EXPECT_EQ(1, runner_i); 72 EXPECT_EQ(1, runner_i);
73 EXPECT_EQ(0, loop_i); 73 EXPECT_EQ(0, loop_i);
74 base::RunLoop().RunUntilIdle(); 74 base::RunLoop().RunUntilIdle();
75 EXPECT_EQ(1, loop_i); 75 EXPECT_EQ(1, loop_i);
76 } 76 }
77 77
78 void CheckSignaledAndPostIncrement( 78 void CheckSignaledAndPostIncrement(
79 OneShotEvent* event, 79 OneShotEvent* event,
80 const scoped_refptr<base::SingleThreadTaskRunner>& runner, 80 const scoped_refptr<base::SingleThreadTaskRunner>& runner,
81 int* i) { 81 int* i) {
82 EXPECT_TRUE(event->is_signaled()); 82 EXPECT_TRUE(event->is_signaled());
83 event->Post(FROM_HERE, base::Bind(&Increment, i), runner); 83 event->Post(FROM_HERE, base::Bind(&Increment, i), runner);
84 } 84 }
85 85
86 TEST(OneShotEventTest, IsSignaledAndPostsFromCallbackWork) { 86 TEST(OneShotEventTest, IsSignaledAndPostsFromCallbackWork) {
87 OneShotEvent event; 87 OneShotEvent event;
88 scoped_refptr<base::TestSimpleTaskRunner> runner( 88 scoped_refptr<base::TestSimpleTaskRunner> runner(
89 new base::TestSimpleTaskRunner); 89 new base::TestSimpleTaskRunner);
90 int i = 0; 90 int i = 0;
91 91
92 event.Post(FROM_HERE, 92 event.Post(FROM_HERE,
93 base::Bind(&CheckSignaledAndPostIncrement, &event, runner, &i), 93 base::Bind(&CheckSignaledAndPostIncrement, &event, runner, &i),
94 runner); 94 runner);
95 EXPECT_EQ(0, i); 95 EXPECT_EQ(0, i);
96 event.Signal(); 96 event.Signal();
97 97
98 // CheckSignaledAndPostIncrement is queued on |runner|. 98 // CheckSignaledAndPostIncrement is queued on |runner|.
99 EXPECT_EQ(1U, runner->GetPendingTasks().size()); 99 EXPECT_EQ(1U, runner->NumPendingTasks());
100 EXPECT_EQ(0, i); 100 EXPECT_EQ(0, i);
101 runner->RunPendingTasks(); 101 runner->RunPendingTasks();
102 // Increment is queued on |runner|. 102 // Increment is queued on |runner|.
103 EXPECT_EQ(1U, runner->GetPendingTasks().size()); 103 EXPECT_EQ(1U, runner->NumPendingTasks());
104 EXPECT_EQ(0, i); 104 EXPECT_EQ(0, i);
105 runner->RunPendingTasks(); 105 runner->RunPendingTasks();
106 // Increment has run. 106 // Increment has run.
107 EXPECT_EQ(0U, runner->GetPendingTasks().size()); 107 EXPECT_EQ(0U, runner->NumPendingTasks());
108 EXPECT_EQ(1, i); 108 EXPECT_EQ(1, i);
109 } 109 }
110 110
111 } // namespace 111 } // namespace
112 } // namespace extensions 112 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/notifications/extension_welcome_notification_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698