chrome/browser/geolocation/chrome_geolocation_permission_context.h - Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context.h

Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments / fix tests Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/permission_queue_controller_unittest.cc ('k') | chrome/browser/geolocation/chrome_geolocation_permission_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/chrome_geolocation_permission_context.h

diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context.h b/chrome/browser/geolocation/chrome_geolocation_permission_context.h

index 0c7e600335367a3ad3e4ca8347b78bc974de1151..ef1383879d9671b94fc9f0480a14b271314b5767 100644

--- a/chrome/browser/geolocation/chrome_geolocation_permission_context.h

+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context.h

@@ -69,6 +69,7 @@ class ChromeGeolocationPermissionContext

const PermissionRequestID& id,

const GURL& requesting_frame,

const GURL& embedder,

+ const std::string& accept_button_label,

base::Callback<void(bool)> callback);

// Called when permission is granted without interactively asking

@@ -89,6 +90,13 @@ class ChromeGeolocationPermissionContext

// Removes any pending InfoBar request.

void CancelPendingInfobarRequest(const PermissionRequestID& id);

+ // Creates and show an info bar.

+ void CreateInfoBarRequest(const PermissionRequestID& id,

+ const GURL& requesting_frame,

+ const GURL& embedder,

+ const std::string accept_button_label,

+ base::Callback<void(bool)> callback);

// These must only be accessed from the UI thread.

Profile* const profile_;

bool shutting_down_;