chrome/browser/content_settings/permission_queue_controller_unittest.cc - Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/permission_queue_controller_unittest.cc

Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments / fix tests Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/permission_queue_controller.cc ('k') | chrome/browser/geolocation/chrome_geolocation_permission_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/permission_queue_controller_unittest.cc

diff --git a/chrome/browser/content_settings/permission_queue_controller_unittest.cc b/chrome/browser/content_settings/permission_queue_controller_unittest.cc

index 717eef2e16815c2b80ee9d769c197b882aabb159..1b70408ecc71c5ae2686a901210d10b20dbd2ecb 100644

--- a/chrome/browser/content_settings/permission_queue_controller_unittest.cc

+++ b/chrome/browser/content_settings/permission_queue_controller_unittest.cc

@@ -96,8 +96,10 @@ TEST_F(PermissionQueueControllerTests, OneObservationPerInfoBarCancelled) {

ObservationCountingQueueController queue_controller(profile());

GURL url("http://www.example.com/geolocation");

base::Callback<void(bool)> callback;

- queue_controller.CreateInfoBarRequest(RequestID(0), url, url, callback);

- queue_controller.CreateInfoBarRequest(RequestID(1), url, url, callback);

+ queue_controller.CreateInfoBarRequest(

+ RequestID(0), url, url, "Accept", callback);

+ queue_controller.CreateInfoBarRequest(

+ RequestID(1), url, url, "Accept", callback);

queue_controller.CancelInfoBarRequest(RequestID(0));

EXPECT_EQ(1, queue_controller.call_count());

};