Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5076)

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context.cc

Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments / fix tests Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/geolocation/chrome_geolocation_permission_context.cc
diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context.cc b/chrome/browser/geolocation/chrome_geolocation_permission_context.cc
index e414cb3045b5e59679755d18bb85ffc1ca786544..412793c785dfdf3be86e11ac68d4a8abe3e223f6 100644
--- a/chrome/browser/geolocation/chrome_geolocation_permission_context.cc
+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context.cc
@@ -189,7 +189,7 @@ void ChromeGeolocationPermissionContext::RequestGeolocationPermission(
}
DecidePermission(web_contents, id, requesting_frame_origin,
- embedder, callback);
+ embedder, "", callback);
}
void ChromeGeolocationPermissionContext::CancelGeolocationPermissionRequest(
@@ -206,6 +206,7 @@ void ChromeGeolocationPermissionContext::DecidePermission(
const PermissionRequestID& id,
const GURL& requesting_frame,
const GURL& embedder,
+ const std::string& accept_button_label,
base::Callback<void(bool)> callback) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
@@ -230,13 +231,26 @@ void ChromeGeolocationPermissionContext::DecidePermission(
} else {
// setting == ask. Prompt the user.
QueueController()->CreateInfoBarRequest(
- id, requesting_frame, embedder, base::Bind(
- &ChromeGeolocationPermissionContext::NotifyPermissionSet,
+ id, requesting_frame, embedder, accept_button_label,
+ base::Bind(
+ &ChromeGeolocationPermissionContext::NotifyPermissionSet,
base::Unretained(this), id, requesting_frame, callback));
}
}
}
+void ChromeGeolocationPermissionContext::CreateInfoBarRequest(
+ const PermissionRequestID& id,
+ const GURL& requesting_frame,
+ const GURL& embedder,
+ const std::string accept_button_label,
+ base::Callback<void(bool)> callback) {
+ QueueController()->CreateInfoBarRequest(
+ id, requesting_frame, embedder, accept_button_label, base::Bind(
+ &ChromeGeolocationPermissionContext::NotifyPermissionSet,
+ base::Unretained(this), id, requesting_frame, callback));
+}
+
void ChromeGeolocationPermissionContext::ShutdownOnUIThread() {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
permission_queue_controller_.reset();

Powered by Google App Engine
This is Rietveld 408576698