Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1880)

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context_android.h

Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments / fix tests Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/geolocation/chrome_geolocation_permission_context_android.h
diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context_android.h b/chrome/browser/geolocation/chrome_geolocation_permission_context_android.h
index aed2ed81d00778b2366167feb95aa67595500139..f3b0898c2c0c8317db752ed204209d33c2509e47 100644
--- a/chrome/browser/geolocation/chrome_geolocation_permission_context_android.h
+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context_android.h
@@ -30,6 +30,7 @@ class ChromeGeolocationPermissionContextAndroid
const PermissionRequestID& id,
const GURL& requesting_frame,
const GURL& embedder,
+ const std::string& accept_button_label,
base::Callback<void(bool)> callback) OVERRIDE;
virtual void PermissionDecided(const PermissionRequestID& id,
@@ -38,8 +39,22 @@ class ChromeGeolocationPermissionContextAndroid
base::Callback<void(bool)> callback,
bool allowed) OVERRIDE;
+ void ProceedDecidePermission(content::WebContents* web_contents,
+ const PermissionRequestID& id,
+ const GURL& requesting_frame,
+ const GURL& embedder,
+ const std::string& accept_button_label,
+ base::Callback<void(bool)> callback);
+
scoped_ptr<GoogleLocationSettingsHelper> google_location_settings_helper_;
+ private:
+ void CheckMasterLocation(content::WebContents* web_contents,
+ const PermissionRequestID& id,
+ const GURL& requesting_frame,
+ const GURL& embedder,
+ base::Callback<void(bool)> callback);
+
DISALLOW_COPY_AND_ASSIGN(ChromeGeolocationPermissionContextAndroid);
};

Powered by Google App Engine
This is Rietveld 408576698