Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: chrome/browser/content_settings/permission_queue_controller_unittest.cc

Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments / fix tests Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/content_settings/permission_queue_controller.h" 5 #include "chrome/browser/content_settings/permission_queue_controller.h"
6 6
7 #include "base/synchronization/waitable_event.h" 7 #include "base/synchronization/waitable_event.h"
8 #include "chrome/browser/chrome_notification_types.h" 8 #include "chrome/browser/chrome_notification_types.h"
9 #include "chrome/browser/content_settings/permission_request_id.h" 9 #include "chrome/browser/content_settings/permission_request_id.h"
10 #include "chrome/browser/infobars/infobar_service.h" 10 #include "chrome/browser/infobars/infobar_service.h"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 // maintain its registration for notifications with the helper, but on the 89 // maintain its registration for notifications with the helper, but on the
90 // last infobar cancellation it should unregister for notifications. 90 // last infobar cancellation it should unregister for notifications.
91 // 91 //
92 // What we don't want is for the controller to unregister and then re-register 92 // What we don't want is for the controller to unregister and then re-register
93 // for notifications, which can lead to getting notified multiple times. This 93 // for notifications, which can lead to getting notified multiple times. This
94 // test checks that in the case where the controller should remain registered 94 // test checks that in the case where the controller should remain registered
95 // for notifications, it gets notified exactly once." 95 // for notifications, it gets notified exactly once."
96 ObservationCountingQueueController queue_controller(profile()); 96 ObservationCountingQueueController queue_controller(profile());
97 GURL url("http://www.example.com/geolocation"); 97 GURL url("http://www.example.com/geolocation");
98 base::Callback<void(bool)> callback; 98 base::Callback<void(bool)> callback;
99 queue_controller.CreateInfoBarRequest(RequestID(0), url, url, callback); 99 queue_controller.CreateInfoBarRequest(
100 queue_controller.CreateInfoBarRequest(RequestID(1), url, url, callback); 100 RequestID(0), url, url, "Accept", callback);
101 queue_controller.CreateInfoBarRequest(
102 RequestID(1), url, url, "Accept", callback);
101 queue_controller.CancelInfoBarRequest(RequestID(0)); 103 queue_controller.CancelInfoBarRequest(RequestID(0));
102 EXPECT_EQ(1, queue_controller.call_count()); 104 EXPECT_EQ(1, queue_controller.call_count());
103 }; 105 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698