Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Unified Diff: chrome/browser/android/google_location_settings_helper.h

Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments / fix tests Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/google_location_settings_helper.h
diff --git a/chrome/browser/android/google_location_settings_helper.h b/chrome/browser/android/google_location_settings_helper.h
index 6bf5853183d98eaea7ccd212fbf85294aafd5e1d..6d6a513fa72be06fe6d6031fefaad2462c7b0bbd 100644
--- a/chrome/browser/android/google_location_settings_helper.h
+++ b/chrome/browser/android/google_location_settings_helper.h
@@ -17,8 +17,11 @@ class GoogleLocationSettingsHelper {
static GoogleLocationSettingsHelper* Create();
- virtual std::string GetAcceptButtonLabel() = 0;
+ virtual std::string GetAcceptButtonLabel(bool allow) = 0;
virtual void ShowGoogleLocationSettings() = 0;
+ // Checks both Master and Google Apps location setting to see
+ // if we should use "Allow" in the accept button.
+ virtual bool IsAllowLabel() = 0;
virtual bool IsMasterLocationSettingEnabled() = 0;
virtual bool IsGoogleAppsLocationSettingEnabled() = 0;

Powered by Google App Engine
This is Rietveld 408576698