Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: chrome/browser/android/google_location_settings_helper.h

Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments / fix tests Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_GOOGLE_LOCATION_SETTINGS_HELPER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_GOOGLE_LOCATION_SETTINGS_HELPER_H_
6 #define CHROME_BROWSER_ANDROID_GOOGLE_LOCATION_SETTINGS_HELPER_H_ 6 #define CHROME_BROWSER_ANDROID_GOOGLE_LOCATION_SETTINGS_HELPER_H_
7 7
8 #include "base/values.h" 8 #include "base/values.h"
9 9
10 // This class is needed to fetch the current system location 10 // This class is needed to fetch the current system location
11 // setting and update the infobar button label based on that information i.e, 11 // setting and update the infobar button label based on that information i.e,
12 // display "Allow" if google apps setting is set as enabled else, display 12 // display "Allow" if google apps setting is set as enabled else, display
13 // "Settings" with a link to open the system location settings activity. 13 // "Settings" with a link to open the system location settings activity.
14 class GoogleLocationSettingsHelper { 14 class GoogleLocationSettingsHelper {
15 public: 15 public:
16 virtual ~GoogleLocationSettingsHelper() {} 16 virtual ~GoogleLocationSettingsHelper() {}
17 17
18 static GoogleLocationSettingsHelper* Create(); 18 static GoogleLocationSettingsHelper* Create();
19 19
20 virtual std::string GetAcceptButtonLabel() = 0; 20 virtual std::string GetAcceptButtonLabel(bool allow) = 0;
21 virtual void ShowGoogleLocationSettings() = 0; 21 virtual void ShowGoogleLocationSettings() = 0;
22 // Checks both Master and Google Apps location setting to see
23 // if we should use "Allow" in the accept button.
24 virtual bool IsAllowLabel() = 0;
22 virtual bool IsMasterLocationSettingEnabled() = 0; 25 virtual bool IsMasterLocationSettingEnabled() = 0;
23 virtual bool IsGoogleAppsLocationSettingEnabled() = 0; 26 virtual bool IsGoogleAppsLocationSettingEnabled() = 0;
24 27
25 protected: 28 protected:
26 GoogleLocationSettingsHelper() {} 29 GoogleLocationSettingsHelper() {}
27 30
28 private: 31 private:
29 32
30 DISALLOW_COPY_AND_ASSIGN(GoogleLocationSettingsHelper); 33 DISALLOW_COPY_AND_ASSIGN(GoogleLocationSettingsHelper);
31 }; 34 };
32 35
33 #endif // CHROME_BROWSER_ANDROID_GOOGLE_LOCATION_SETTINGS_HELPER_H_ 36 #endif // CHROME_BROWSER_ANDROID_GOOGLE_LOCATION_SETTINGS_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698