chrome/android/testshell/testshell_google_location_settings_helper.cc - Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/testshell/testshell_google_location_settings_helper.cc

Issue 23345004: Fix Android strict-mode violation in GeoLocation info bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments / fix tests Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/testshell/testshell_google_location_settings_helper.h ('k') | chrome/browser/android/google_location_settings_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/testshell/testshell_google_location_settings_helper.cc

diff --git a/chrome/android/testshell/testshell_google_location_settings_helper.cc b/chrome/android/testshell/testshell_google_location_settings_helper.cc

index fe34ec3178f968160653229b3a7e0ca11f54124d..f109d5502b473cc04cc99c408598d54c467ca0df 100644

--- a/chrome/android/testshell/testshell_google_location_settings_helper.cc

+++ b/chrome/android/testshell/testshell_google_location_settings_helper.cc

@@ -17,7 +17,8 @@ TestShellGoogleLocationSettingsHelper::

~TestShellGoogleLocationSettingsHelper() {

}

-std::string TestShellGoogleLocationSettingsHelper::GetAcceptButtonLabel() {

+std::string TestShellGoogleLocationSettingsHelper::GetAcceptButtonLabel(

+ bool allow) {

return "Allow";

}

@@ -32,3 +33,7 @@ bool TestShellGoogleLocationSettingsHelper::

bool TestShellGoogleLocationSettingsHelper::IsMasterLocationSettingEnabled() {

return true;

}

+bool TestShellGoogleLocationSettingsHelper::IsAllowLabel() {

+ return true;