Delete chrome_framework_locales in favour of copy_data_to_bundle=true

Delete chrome_framework_locales in favour of copy_data_to_bundle=true

BUG=645716
Committed: https://crrev.com/aed96bd67be5d31cf8fa357de1f5ce921f4645cb
Cr-Commit-Position: refs/heads/master@{#418901}

[agrieve, 2016-09-13 14:49:50]

agrieve@chromium.org changed reviewers:
+ thakis@chromium.org

[agrieve, 2016-09-13 14:49:51]

This simplifies things a bit in prep for refactoring chrome repack rules, which
is in progress here: https://codereview.chromium.org/2336033002

Overall motivation for these changes is to be able to easily define different
repack targets for monochrome vs chrome, so that they can use appropriate
resource whitelists (which are tied to .so files)

[Nico, 2016-09-13 14:52:54]

thakis@chromium.org changed reviewers:
+ rsesek@chromium.org

[Nico, 2016-09-13 14:52:54]

+rsesek who wrote chrome_framework_locales

[Robert Sesek, 2016-09-13 17:18:27]

Accidentally wrote on the dependency instead: LGTM. But please run a clobber
tryjob on Mac to make sure this is OK.

[agrieve, 2016-09-13 19:50:59]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 19:51:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 20:52:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 20:52:03]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-09-15 14:55:28]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 14:55:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2016-09-15 15:57:03]

On 2016/09/13 17:18:27, Robert Sesek wrote:
> Accidentally wrote on the dependency instead: LGTM. But please run a clobber
> tryjob on Mac to make sure this is OK.

Clobber build showed:
[59554:1287:0915/083539:FATAL:chrome_browser_main_mac.mm(116)] Check failed:
!loaded_locale.empty(). Default locale could not be found
0   Chromium Framework                  0x0000000108a150d3
_ZN4base5debug10StackTraceC1Ev + 19
1   Chromium Framework                  0x0000000108a370f7
_ZN7logging10LogMessageD2Ev + 71
2   Chromium Framework                  0x00000001084d92a9
_ZN25ChromeBrowserMainPartsMac23PreMainMessageLoopStartEv + 233
3   Chromium Framework                  0x000000010776e9d3
_ZN7content15BrowserMainLoop23PreMainMessageLoopStartEv + 67
4   Chromium Framework                  0x00000001077750d8
_ZN7content21BrowserMainRunnerImpl10InitializeERKNS_18MainFunctionParamsE + 440
5   Chromium Framework                  0x000000010776de84
_ZN7content11BrowserMainERKNS_18MainFunctionParamsE + 100
6   Chromium Framework                  0x000000010847e48e
_ZN7content21ContentMainRunnerImpl3RunEv + 798
7   Chromium Framework                  0x000000010847d436
_ZN7content11ContentMainERKNS_17ContentMainParamsE + 54
8   Chromium Framework                  0x00000001066884ea ChromeMain + 58
9   Chromium                            0x0000000106620d5a main + 522
10  Chromium                            0x0000000106620b44 start + 52

[agrieve, 2016-09-15 16:55:00]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 16:55:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2016-09-15 16:55:21]

On 2016/09/15 15:57:03, agrieve wrote:
> On 2016/09/13 17:18:27, Robert Sesek wrote:
> > Accidentally wrote on the dependency instead: LGTM. But please run a clobber
> > tryjob on Mac to make sure this is OK.
> 
> Clobber build showed:
> [59554:1287:0915/083539:FATAL:chrome_browser_main_mac.mm(116)] Check failed:
> !loaded_locale.empty(). Default locale could not be found
> 0   Chromium Framework                  0x0000000108a150d3
> _ZN4base5debug10StackTraceC1Ev + 19
> 1   Chromium Framework                  0x0000000108a370f7
> _ZN7logging10LogMessageD2Ev + 71
> 2   Chromium Framework                  0x00000001084d92a9
> _ZN25ChromeBrowserMainPartsMac23PreMainMessageLoopStartEv + 233
> 3   Chromium Framework                  0x000000010776e9d3
> _ZN7content15BrowserMainLoop23PreMainMessageLoopStartEv + 67
> 4   Chromium Framework                  0x00000001077750d8
> _ZN7content21BrowserMainRunnerImpl10InitializeERKNS_18MainFunctionParamsE +
440
> 5   Chromium Framework                  0x000000010776de84
> _ZN7content11BrowserMainERKNS_18MainFunctionParamsE + 100
> 6   Chromium Framework                  0x000000010847e48e
> _ZN7content21ContentMainRunnerImpl3RunEv + 798
> 7   Chromium Framework                  0x000000010847d436
> _ZN7content11ContentMainERKNS_17ContentMainParamsE + 54
> 8   Chromium Framework                  0x00000001066884ea ChromeMain + 58
> 9   Chromium                            0x0000000106620d5a main + 522
> 10  Chromium                            0x0000000106620b44 start + 52

looks to have fixed it :). Again, thanks for the clobber-bot tip!

[Nico, 2016-09-15 16:59:56]

lgtm, but rsesek might want to take another look at patch set 3

[Robert Sesek, 2016-09-15 17:31:31]

lgtm

[agrieve, 2016-09-15 17:37:12]

The CQ bit was unchecked by agrieve@chromium.org

[agrieve, 2016-09-15 17:37:17]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-09-15 17:37:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 17:51:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-15 17:54:20]

Description was changed from

==========
Delete chrome_framework_locales in favour of copy_data_to_bundle=true

BUG=645716
==========

to

==========
Delete chrome_framework_locales in favour of copy_data_to_bundle=true

BUG=645716

Committed: https://crrev.com/aed96bd67be5d31cf8fa357de1f5ce921f4645cb
Cr-Commit-Position: refs/heads/master@{#418901}
==========

[commit-bot: I haz the power, 2016-09-15 17:54:21]

Patchset 3 (id:??) landed as
https://crrev.com/aed96bd67be5d31cf8fa357de1f5ce921f4645cb
Cr-Commit-Position: refs/heads/master@{#418901}