Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: chrome/BUILD.gn

Issue 2334213002: Delete chrome_framework_locales in favour of copy_data_to_bundle=true (Closed)
Patch Set: speculative fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/grit/repack.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 684 matching lines...) Expand 10 before | Expand all | Expand 10 after
695 # Remove the default strip configuration (which strips all symbols) so that 695 # Remove the default strip configuration (which strips all symbols) so that
696 # a saves file can be specified. 696 # a saves file can be specified.
697 if (enable_stripping) { 697 if (enable_stripping) {
698 remove_configs = [ "//build/config/mac:strip_all" ] 698 remove_configs = [ "//build/config/mac:strip_all" ]
699 699
700 ldflags += 700 ldflags +=
701 [ "-Wcrl,strip,-s," + rebase_path("app/app.saves", root_build_dir) ] 701 [ "-Wcrl,strip,-s," + rebase_path("app/app.saves", root_build_dir) ]
702 } 702 }
703 } 703 }
704 704
705 bundle_data("chrome_framework_locales") {
706 sources = []
707 public_deps = [
708 ":repack_locales_pack",
709 ]
710
711 foreach(locale, locales_as_mac_outputs) {
712 sources += [ "$root_gen_dir/repack/locales/$locale.pak" ]
713 }
714
715 outputs = [
716 "{{bundle_resources_dir}}/{{source_name_part}}.lproj/locale.pak",
717 ]
718 }
719
720 bundle_data("chrome_framework_helpers") { 705 bundle_data("chrome_framework_helpers") {
721 sources = [ 706 sources = [
722 "$root_out_dir/crashpad_handler", 707 "$root_out_dir/crashpad_handler",
723 ] 708 ]
724 709
725 outputs = [ 710 outputs = [
726 "{{bundle_root_dir}}/Helpers/{{source_file_part}}", 711 "{{bundle_root_dir}}/Helpers/{{source_file_part}}",
727 ] 712 ]
728 713
729 public_deps = [ 714 public_deps = [
730 "//third_party/crashpad/crashpad/handler:crashpad_handler", 715 "//third_party/crashpad/crashpad/handler:crashpad_handler",
731 ] 716 ]
732 717
733 if (using_sanitizer) { 718 if (using_sanitizer) {
734 # crashpad_handler requires the ASan runtime at its @executable_path. 719 # crashpad_handler requires the ASan runtime at its @executable_path.
735 sources += [ "$root_out_dir/libclang_rt.asan_osx_dynamic.dylib" ] 720 sources += [ "$root_out_dir/libclang_rt.asan_osx_dynamic.dylib" ]
736 public_deps += [ "//build/config/sanitizers:copy_asan_runtime" ] 721 public_deps += [ "//build/config/sanitizers:copy_asan_runtime" ]
737 } 722 }
738 } 723 }
739 724
740 bundle_data("chrome_framework_resources") { 725 bundle_data("chrome_framework_resources") {
741 sources = [ 726 sources = [
727 "$root_out_dir/app_mode_loader.app",
728
742 # This image is used to badge the lock icon in the 729 # This image is used to badge the lock icon in the
743 # authentication dialogs, such as those used for installation 730 # authentication dialogs, such as those used for installation
744 # from disk image and Keystone promotion (if so enabled). It 731 # from disk image and Keystone promotion (if so enabled). It
745 # needs to exist as a file on disk and not just something in a 732 # needs to exist as a file on disk and not just something in a
746 # resource bundle because that's the interface that 733 # resource bundle because that's the interface that
747 # Authorization Services uses. Also, Authorization Services 734 # Authorization Services uses. Also, Authorization Services
748 # can't deal with .icns files. 735 # can't deal with .icns files.
749 "$root_gen_dir/repack/resources.pak",
750 "$root_out_dir/app_mode_loader.app",
751 "$root_out_dir/chrome_100_percent.pak",
752 "app/theme/default_100_percent/$branding_path_component/product_logo_32.pn g", 736 "app/theme/default_100_percent/$branding_path_component/product_logo_32.pn g",
753 "browser/mac/install.sh", 737 "browser/mac/install.sh",
754 ] 738 ]
755 739
756 outputs = [ 740 outputs = [
757 "{{bundle_resources_dir}}/{{source_file_part}}", 741 "{{bundle_resources_dir}}/{{source_file_part}}",
758 ] 742 ]
759 743
760 public_deps = [ 744 public_deps = [
761 ":packed_extra_resources", 745 ":packed_extra_resources",
762 ":packed_resources", 746 ":packed_resources",
763 "//chrome/app_shim:app_mode_loader", 747 "//chrome/app_shim:app_mode_loader",
764 ] 748 ]
765 749
766 if (enable_hidpi) {
767 sources += [ "$root_out_dir/chrome_200_percent.pak" ]
768 }
769
770 if (enable_mac_keystone) { 750 if (enable_mac_keystone) {
771 sources += [ 751 sources += [
772 "browser/mac/keystone_promote_postflight.sh", 752 "browser/mac/keystone_promote_postflight.sh",
773 "browser/mac/keystone_promote_preflight.sh", 753 "browser/mac/keystone_promote_preflight.sh",
774 ] 754 ]
775 } 755 }
776 756
777 if (icu_use_data_file) { 757 if (icu_use_data_file) {
778 sources += [ "$root_out_dir/icudtl.dat" ] 758 sources += [ "$root_out_dir/icudtl.dat" ]
779 public_deps += [ "//third_party/icu:icudata" ] 759 public_deps += [ "//third_party/icu:icudata" ]
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
1008 "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id", 988 "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
1009 "CHROMIUM_SHORT_NAME=$chrome_product_short_name", 989 "CHROMIUM_SHORT_NAME=$chrome_product_short_name",
1010 ] 990 ]
1011 991
1012 public_deps = [ 992 public_deps = [
1013 ":chrome_dll", 993 ":chrome_dll",
1014 ] 994 ]
1015 995
1016 deps = [ 996 deps = [
1017 ":chrome_framework_helpers", 997 ":chrome_framework_helpers",
1018 ":chrome_framework_locales",
1019 ":chrome_framework_plugins", 998 ":chrome_framework_plugins",
1020 ":chrome_framework_resources", 999 ":chrome_framework_resources",
1000 ":repack_locales_pack",
1021 ":widevine_cdm_library", 1001 ":widevine_cdm_library",
1022 "//build/config/sanitizers:deps", 1002 "//build/config/sanitizers:deps",
1023 "//chrome/app/nibs:chrome_xibs", 1003 "//chrome/app/nibs:chrome_xibs",
1024 ] 1004 ]
1025 1005
1026 if (is_chrome_branded) { 1006 if (is_chrome_branded) {
1027 deps += [ ":default_apps" ] 1007 deps += [ ":default_apps" ]
1028 } 1008 }
1029 1009
1030 ldflags = [ 1010 ldflags = [
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
1444 ] 1424 ]
1445 deps += [ "//extensions:extensions_resources" ] 1425 deps += [ "//extensions:extensions_resources" ]
1446 } 1426 }
1447 1427
1448 if (is_mac) { 1428 if (is_mac) {
1449 output = "$root_gen_dir/repack/resources.pak" 1429 output = "$root_gen_dir/repack/resources.pak"
1450 } else { 1430 } else {
1451 output = "$root_out_dir/resources.pak" 1431 output = "$root_out_dir/resources.pak"
1452 } 1432 }
1453 1433
1434 copy_data_to_bundle = is_mac
1454 if (enable_resource_whitelist_generation) { 1435 if (enable_resource_whitelist_generation) {
1455 repack_whitelist = android_resource_whitelist 1436 repack_whitelist = android_resource_whitelist
1456 deps += [ ":resource_whitelist" ] 1437 deps += [ ":resource_whitelist" ]
1457 } 1438 }
1458 } 1439 }
1459 1440
1460 # GYP version: chrome/chrome_resources.gyp:browser_tests_pak 1441 # GYP version: chrome/chrome_resources.gyp:browser_tests_pak
1461 repack("browser_tests_pak") { 1442 repack("browser_tests_pak") {
1462 sources = [ 1443 sources = [
1463 "$root_gen_dir/chrome/options_test_resources.pak", 1444 "$root_gen_dir/chrome/options_test_resources.pak",
1464 "$root_gen_dir/chrome/webui_test_resources.pak", 1445 "$root_gen_dir/chrome/webui_test_resources.pak",
1465 ] 1446 ]
1466 output = "$root_out_dir/browser_tests.pak" 1447 output = "$root_out_dir/browser_tests.pak"
1467 deps = [ 1448 deps = [
1468 "//chrome/browser/resources:options_test_resources", 1449 "//chrome/browser/resources:options_test_resources",
1469 "//chrome/test/data:webui_test_resources", 1450 "//chrome/test/data:webui_test_resources",
1470 ] 1451 ]
1471 } 1452 }
1472 1453
1473 # Collects per-locale grit files from many sources into global per-locale files. 1454 # Collects per-locale grit files from many sources into global per-locale files.
1474 chrome_repack_locales("repack_locales_pack") { 1455 chrome_repack_locales("repack_locales_pack") {
1475 visibility = [ ":*" ] 1456 visibility = [ ":*" ]
1476 1457
1477 input_locales = locales 1458 input_locales = locales
1459 copy_data_to_bundle = is_mac
1478 1460
1479 if (is_mac) { 1461 if (is_mac) {
1480 output_locales = locales_as_mac_outputs 1462 output_locales = locales_as_mac_outputs
1481 } else { 1463 } else {
1482 output_locales = locales 1464 output_locales = locales
1483 } 1465 }
1484 1466
1485 if (enable_resource_whitelist_generation) { 1467 if (enable_resource_whitelist_generation) {
1486 repack_whitelist = android_resource_whitelist 1468 repack_whitelist = android_resource_whitelist
1487 deps = [ 1469 deps = [
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
1570 if (enable_extensions) { 1552 if (enable_extensions) {
1571 sources += [ "$root_gen_dir/extensions/extensions_browser_resources_${perc ent}_percent.pak" ] 1553 sources += [ "$root_gen_dir/extensions/extensions_browser_resources_${perc ent}_percent.pak" ]
1572 deps += [ "//extensions:extensions_browser_resources" ] 1554 deps += [ "//extensions:extensions_browser_resources" ]
1573 } 1555 }
1574 if (enable_app_list) { 1556 if (enable_app_list) {
1575 sources += [ "$root_gen_dir/ui/app_list/resources/app_list_resources_${per cent}_percent.pak" ] 1557 sources += [ "$root_gen_dir/ui/app_list/resources/app_list_resources_${per cent}_percent.pak" ]
1576 deps += [ "//ui/app_list/resources" ] 1558 deps += [ "//ui/app_list/resources" ]
1577 } 1559 }
1578 1560
1579 output = repack_output_file 1561 output = repack_output_file
1562 copy_data_to_bundle = is_mac
1580 1563
1581 if (enable_resource_whitelist_generation) { 1564 if (enable_resource_whitelist_generation) {
1582 repack_whitelist = android_resource_whitelist 1565 repack_whitelist = android_resource_whitelist
1583 deps += [ ":resource_whitelist" ] 1566 deps += [ ":resource_whitelist" ]
1584 } 1567 }
1585 } 1568 }
1586 1569
1587 copy(copy_name) { 1570 copy(copy_name) {
1588 visibility = [ ":*" ] 1571 visibility = [ ":*" ]
1589 deps = [ 1572 deps = [
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
1799 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1782 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1800 "//chrome/tools/build/linux/chrome-wrapper", 1783 "//chrome/tools/build/linux/chrome-wrapper",
1801 "//third_party/xdg-utils/scripts/xdg-mime", 1784 "//third_party/xdg-utils/scripts/xdg-mime",
1802 "//third_party/xdg-utils/scripts/xdg-settings", 1785 "//third_party/xdg-utils/scripts/xdg-settings",
1803 ] 1786 ]
1804 outputs = [ 1787 outputs = [
1805 "$root_out_dir/{{source_file_part}}", 1788 "$root_out_dir/{{source_file_part}}",
1806 ] 1789 ]
1807 } 1790 }
1808 } 1791 }
OLDNEW
« no previous file with comments | « no previous file | tools/grit/repack.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698