net/socket/socks5_client_socket_unittest.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socks5_client_socket_unittest.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/socks5_client_socket_unittest.cc

diff --git a/net/socket/socks5_client_socket_unittest.cc b/net/socket/socks5_client_socket_unittest.cc

index e5b7e892f80111419f8089801d8113935c40923b..4cf98cffe422a81ae1487eb6b7d3088487e624dc 100644

--- a/net/socket/socks5_client_socket_unittest.cc

+++ b/net/socket/socks5_client_socket_unittest.cc

@@ -15,7 +15,6 @@

#include "net/base/test_completion_callback.h"

#include "net/base/winsock_init.h"

#include "net/dns/mock_host_resolver.h"

-#include "net/log/net_log.h"

#include "net/log/net_log_event_type.h"

#include "net/log/test_net_log.h"

#include "net/log/test_net_log_entry.h"

@@ -35,6 +34,8 @@ using net::test::IsOk;

namespace net {

+class NetLog;

namespace {

// Base class to test SOCKS5ClientSocket