net/socket/socks5_client_socket.h - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socks5_client_socket.h

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/socks5_client_socket.h

diff --git a/net/socket/socks5_client_socket.h b/net/socket/socks5_client_socket.h

index 31907e18cd6f16a44531e188ec89fbc52f67adc1..86165000d3b6d7fef2f151ee2036a74dbdd750c1 100644

--- a/net/socket/socks5_client_socket.h

+++ b/net/socket/socks5_client_socket.h

@@ -17,14 +17,13 @@

#include "net/base/completion_callback.h"

#include "net/base/net_errors.h"

#include "net/dns/host_resolver.h"

-#include "net/log/net_log.h"

+#include "net/log/net_log_with_source.h"

#include "net/socket/stream_socket.h"

#include "url/gurl.h"

namespace net {

class ClientSocketHandle;

-class NetLogWithSource;

// This StreamSocket is used to setup a SOCKSv5 handshake with a socks proxy.

// Currently no SOCKSv5 authentication is supported.