net/socket/client_socket_pool.h - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_pool.h

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/client_socket_pool.h

diff --git a/net/socket/client_socket_pool.h b/net/socket/client_socket_pool.h

index a5c11d64000c3ec1467e41dbba5e1c91fd18b3d6..15dbe5f02d6e09d6e503c6dccb4eab0a268e4949 100644

--- a/net/socket/client_socket_pool.h

+++ b/net/socket/client_socket_pool.h

@@ -25,6 +25,7 @@ class DictionaryValue;

namespace net {

class ClientSocketHandle;

+class NetLogWithSource;

class StreamSocket;

// ClientSocketPools are layered. This defines an interface for lower level