net/socket/client_socket_handle.h - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_handle.h

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/client_socket_handle.h

diff --git a/net/socket/client_socket_handle.h b/net/socket/client_socket_handle.h

index 8d92cb5283d19f63ba686ffc513d1dcc66c4160e..cf9e8d022eebdcb41c0e477007d431bd79f3f8f3 100644

--- a/net/socket/client_socket_handle.h

+++ b/net/socket/client_socket_handle.h

@@ -20,7 +20,8 @@

#include "net/base/net_export.h"

#include "net/base/request_priority.h"

#include "net/http/http_response_info.h"

-#include "net/log/net_log.h"

+#include "net/log/net_log_source.h"

+#include "net/log/net_log_with_source.h"

#include "net/socket/client_socket_pool.h"

#include "net/socket/connection_attempts.h"

#include "net/socket/stream_socket.h"

@@ -219,7 +220,7 @@ class NET_EXPORT ClientSocketHandle {

base::TimeTicks init_time_;

base::TimeDelta setup_time_;

- NetLog::Source requesting_source_;

+ NetLogSource requesting_source_;

// Timing information is set when a connection is successfully established.

LoadTimingInfo::ConnectTiming connect_timing_;