Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: net/proxy/proxy_resolver_v8_tracing_wrapper.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)
Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_resolver_v8_tracing_wrapper.cc
diff --git a/net/proxy/proxy_resolver_v8_tracing_wrapper.cc b/net/proxy/proxy_resolver_v8_tracing_wrapper.cc
index be3a78fe58cc1597ae800658fbca9b5275c221df..c99916cee16ab236307d246329f88c571b741346 100644
--- a/net/proxy/proxy_resolver_v8_tracing_wrapper.cc
+++ b/net/proxy/proxy_resolver_v8_tracing_wrapper.cc
@@ -13,10 +13,14 @@
#include "base/values.h"
#include "net/base/net_errors.h"
#include "net/log/net_log.h"
+#include "net/log/net_log_capture_mode.h"
#include "net/log/net_log_event_type.h"
+#include "net/log/net_log_parameters_callback.h"
+#include "net/log/net_log_with_source.h"
#include "net/proxy/proxy_resolver_error_observer.h"
namespace net {
+
namespace {
// Returns event parameters for a PAC error message (line number + message).
@@ -67,7 +71,7 @@ class BindingsImpl : public ProxyResolverV8Tracing::Bindings {
private:
void LogEventToCurrentRequestAndGlobally(
NetLogEventType type,
- const NetLog::ParametersCallback& parameters_callback) {
+ const NetLogParametersCallback& parameters_callback) {
net_log_with_source_.AddEvent(type, parameters_callback);
// Emit to the global NetLog event stream.

Powered by Google App Engine
This is Rietveld 408576698