net/proxy/proxy_resolver_v8_tracing_unittest.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_resolver_v8_tracing_unittest.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_resolver_v8_tracing_unittest.cc

diff --git a/net/proxy/proxy_resolver_v8_tracing_unittest.cc b/net/proxy/proxy_resolver_v8_tracing_unittest.cc

index d1e305663c4e21910086edf7672e91fb9c8803b2..6967491881b1a27897bf7cb153d57e598094421f 100644

--- a/net/proxy/proxy_resolver_v8_tracing_unittest.cc

+++ b/net/proxy/proxy_resolver_v8_tracing_unittest.cc

@@ -20,7 +20,7 @@

#include "net/base/test_completion_callback.h"

#include "net/dns/host_cache.h"

#include "net/dns/mock_host_resolver.h"

-#include "net/log/net_log.h"

+#include "net/log/net_log_with_source.h"

#include "net/proxy/proxy_info.h"

#include "net/test/event_waiter.h"

#include "net/test/gtest_util.h"