Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: net/cert/multi_log_ct_verifier.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)
Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/multi_log_ct_verifier.cc
diff --git a/net/cert/multi_log_ct_verifier.cc b/net/cert/multi_log_ct_verifier.cc
index f084c0e562a162966365cdd555e05d25cc3c775d..8dc172677a502e92fff9c11eb118b754dbf30d16 100644
--- a/net/cert/multi_log_ct_verifier.cc
+++ b/net/cert/multi_log_ct_verifier.cc
@@ -18,8 +18,9 @@
#include "net/cert/ct_verify_result.h"
#include "net/cert/sct_status_flags.h"
#include "net/cert/x509_certificate.h"
-#include "net/log/net_log.h"
#include "net/log/net_log_event_type.h"
+#include "net/log/net_log_parameters_callback.h"
+#include "net/log/net_log_with_source.h"
namespace net {
@@ -117,9 +118,9 @@ int MultiLogCTVerifier::Verify(X509Certificate* cert,
// Log to Net Log, after extracting SCTs but before possibly failing on
// X.509 entry creation.
- NetLog::ParametersCallback net_log_callback =
- base::Bind(&NetLogRawSignedCertificateTimestampCallback,
- &embedded_scts, &sct_list_from_ocsp, &sct_list_from_tls_extension);
+ NetLogParametersCallback net_log_callback =
+ base::Bind(&NetLogRawSignedCertificateTimestampCallback, &embedded_scts,
+ &sct_list_from_ocsp, &sct_list_from_tls_extension);
net_log.AddEvent(NetLogEventType::SIGNED_CERTIFICATE_TIMESTAMPS_RECEIVED,
net_log_callback);
@@ -135,7 +136,7 @@ int MultiLogCTVerifier::Verify(X509Certificate* cert,
ct::SignedCertificateTimestamp::SCT_FROM_TLS_EXTENSION, cert, result);
}
- NetLog::ParametersCallback net_log_checked_callback =
+ NetLogParametersCallback net_log_checked_callback =
base::Bind(&NetLogSignedCertificateTimestampCallback, result);
net_log.AddEvent(NetLogEventType::SIGNED_CERTIFICATE_TIMESTAMPS_CHECKED,

Powered by Google App Engine
This is Rietveld 408576698