net/cert/ct_signed_certificate_timestamp_log_param.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/ct_signed_certificate_timestamp_log_param.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/ct_signed_certificate_timestamp_log_param.cc

diff --git a/net/cert/ct_signed_certificate_timestamp_log_param.cc b/net/cert/ct_signed_certificate_timestamp_log_param.cc

index 756608190f1b639a5071c37c94eb57e5e32f6be9..6afd32224e50501cc931cf181adb6af3baf2f3d6 100644

--- a/net/cert/ct_signed_certificate_timestamp_log_param.cc

+++ b/net/cert/ct_signed_certificate_timestamp_log_param.cc

@@ -6,7 +6,6 @@

#include <algorithm>

#include <memory>

-#include <string>

#include <utility>

#include "base/base64.h"

@@ -16,6 +15,7 @@

#include "net/cert/ct_sct_to_string.h"

#include "net/cert/ct_verify_result.h"

#include "net/cert/signed_certificate_timestamp.h"

+#include "net/log/net_log_capture_mode.h"

namespace net {