chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/remote_debugging_server.cc ('k') | chrome/browser/extensions/api/cast_streaming/performance_test.cc » ('j') | chrome/browser/extensions/api/log_private/log_private_api.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc

diff --git a/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc b/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc

index 6789ef843c40964e68dba5007d05a87df9f9bf73..848aa5cca59ae9b82e9419c821cf2f4699627357 100644

--- a/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc

+++ b/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc

@@ -31,6 +31,7 @@

#include "media/cast/test/utility/standalone_cast_environment.h"

#include "net/base/net_errors.h"

#include "net/base/rand_callback.h"

+#include "net/log/net_log_source.h"

#include "net/udp/udp_server_socket.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -345,7 +346,7 @@ class CastStreamingApiTestWithPixelOutput : public CastStreamingApiTest {

#endif

IN_PROC_BROWSER_TEST_F(CastStreamingApiTestWithPixelOutput, MAYBE_EndToEnd) {

std::unique_ptr<net::UDPServerSocket> receive_socket(

- new net::UDPServerSocket(NULL, net::NetLog::Source()));

+ new net::UDPServerSocket(NULL, net::NetLogSource()));

receive_socket->AllowAddressReuse();

ASSERT_EQ(net::OK, receive_socket->Listen(GetFreeLocalPort()));

net::IPEndPoint receiver_end_point;