Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5973)

Unified Diff: chrome/browser/devtools/remote_debugging_server.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)
Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/remote_debugging_server.cc
diff --git a/chrome/browser/devtools/remote_debugging_server.cc b/chrome/browser/devtools/remote_debugging_server.cc
index b15c620d794e4323b6e485725a0523079936fdee..7606b415f16fa5efc92f58a0338f0500b155ed99 100644
--- a/chrome/browser/devtools/remote_debugging_server.cc
+++ b/chrome/browser/devtools/remote_debugging_server.cc
@@ -23,6 +23,7 @@
#include "content/public/browser/devtools_frontend_host.h"
#include "content/public/browser/devtools_socket_factory.h"
#include "net/base/net_errors.h"
+#include "net/log/net_log_source.h"
#include "net/socket/tcp_server_socket.h"
#include "ui/base/resource/resource_bundle.h"
@@ -45,7 +46,7 @@ class TCPServerSocketFactory
private:
std::unique_ptr<net::ServerSocket> CreateLocalHostServerSocket(int port) {
std::unique_ptr<net::ServerSocket> socket(
- new net::TCPServerSocket(nullptr, net::NetLog::Source()));
+ new net::TCPServerSocket(nullptr, net::NetLogSource()));
if (socket->ListenWithAddressAndPort(
"127.0.0.1", port, kBackLog) == net::OK)
return socket;
@@ -57,7 +58,7 @@ class TCPServerSocketFactory
// content::DevToolsSocketFactory.
std::unique_ptr<net::ServerSocket> CreateForHttpServer() override {
std::unique_ptr<net::ServerSocket> socket(
- new net::TCPServerSocket(nullptr, net::NetLog::Source()));
+ new net::TCPServerSocket(nullptr, net::NetLogSource()));
if (address_.empty())
return CreateLocalHostServerSocket(port_);
if (socket->ListenWithAddressAndPort(address_, port_, kBackLog) == net::OK)

Powered by Google App Engine
This is Rietveld 408576698