Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2275)

Unified Diff: chrome/browser/extensions/activity_log/activity_log_browsertest.cc

Issue 233353003: Only commit cookie changes in prerenders after a prerender is shown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Add browser tests, fix a bug in what was changed yesterday. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_log_browsertest.cc
===================================================================
--- chrome/browser/extensions/activity_log/activity_log_browsertest.cc (revision 265252)
+++ chrome/browser/extensions/activity_log/activity_log_browsertest.cc (working copy)
@@ -12,7 +12,10 @@
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/ui_test_utils.h"
+#include "content/public/browser/browser_context.h"
+#include "content/public/browser/browser_thread.h"
#include "content/public/browser/notification_service.h"
+#include "content/public/browser/storage_partition.h"
#include "content/public/test/browser_test_utils.h"
#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
@@ -99,6 +102,14 @@
"http://www.google.com.bo:%d/test.html",
port));
+ if (!prerender_manager->cookie_store_loaded()) {
+ prerender_manager->set_on_cookie_store_loaded_cb(
+ base::Bind(
+ &base::MessageLoop::Quit,
+ base::Unretained(base::MessageLoop::current())));
+ base::MessageLoop::current()->Run();
+ }
+
const gfx::Size kSize(640, 480);
scoped_ptr<prerender::PrerenderHandle> prerender_handle(
prerender_manager->AddPrerenderFromLocalPredictor(

Powered by Google App Engine
This is Rietveld 408576698