Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chrome/browser/prerender/external_prerender_handler_android.cc

Issue 233353003: Only commit cookie changes in prerenders after a prerender is shown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Add browser tests, fix a bug in what was changed yesterday. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/external_prerender_handler_android.cc
===================================================================
--- chrome/browser/prerender/external_prerender_handler_android.cc (revision 265252)
+++ chrome/browser/prerender/external_prerender_handler_android.cc (working copy)
@@ -89,6 +89,17 @@
return prerender_manager->HasPrerenderedUrl(url, web_contents);
}
+static jboolean HasCookieStoreLoaded(JNIEnv* env,
+ jclass clazz,
+ jobject jprofile) {
+ Profile* profile = ProfileAndroid::FromProfileAndroid(jprofile);
+ prerender::PrerenderManager* prerender_manager =
+ prerender::PrerenderManagerFactory::GetForProfile(profile);
Charlie Reis 2014/05/07 17:21:32 nit: Looks like wrong indent.
tburkard 2014/05/07 18:34:27 Done.
+ if (!prerender_manager)
+ return false;
+ return prerender_manager->cookie_store_loaded();
+}
+
ExternalPrerenderHandlerAndroid::ExternalPrerenderHandlerAndroid() {}
ExternalPrerenderHandlerAndroid::~ExternalPrerenderHandlerAndroid() {}

Powered by Google App Engine
This is Rietveld 408576698