Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: chrome/browser/extensions/activity_log/activity_log_browsertest.cc

Issue 233353003: Only commit cookie changes in prerenders after a prerender is shown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Add browser tests, fix a bug in what was changed yesterday. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/stringprintf.h" 5 #include "base/strings/stringprintf.h"
6 #include "chrome/browser/extensions/activity_log/activity_log.h" 6 #include "chrome/browser/extensions/activity_log/activity_log.h"
7 #include "chrome/browser/extensions/extension_apitest.h" 7 #include "chrome/browser/extensions/extension_apitest.h"
8 #include "chrome/browser/extensions/extension_browsertest.h" 8 #include "chrome/browser/extensions/extension_browsertest.h"
9 #include "chrome/browser/prerender/prerender_handle.h" 9 #include "chrome/browser/prerender/prerender_handle.h"
10 #include "chrome/browser/prerender/prerender_manager.h" 10 #include "chrome/browser/prerender/prerender_manager.h"
11 #include "chrome/browser/prerender/prerender_manager_factory.h" 11 #include "chrome/browser/prerender/prerender_manager_factory.h"
12 #include "chrome/browser/ui/tabs/tab_strip_model.h" 12 #include "chrome/browser/ui/tabs/tab_strip_model.h"
13 #include "chrome/common/chrome_switches.h" 13 #include "chrome/common/chrome_switches.h"
14 #include "chrome/test/base/ui_test_utils.h" 14 #include "chrome/test/base/ui_test_utils.h"
15 #include "content/public/browser/browser_context.h"
16 #include "content/public/browser/browser_thread.h"
15 #include "content/public/browser/notification_service.h" 17 #include "content/public/browser/notification_service.h"
18 #include "content/public/browser/storage_partition.h"
16 #include "content/public/test/browser_test_utils.h" 19 #include "content/public/test/browser_test_utils.h"
17 #include "net/dns/mock_host_resolver.h" 20 #include "net/dns/mock_host_resolver.h"
18 #include "net/test/embedded_test_server/embedded_test_server.h" 21 #include "net/test/embedded_test_server/embedded_test_server.h"
19 22
20 namespace extensions { 23 namespace extensions {
21 24
22 // Only the prerender tests are in this file. To add tests for activity 25 // Only the prerender tests are in this file. To add tests for activity
23 // logging please see: 26 // logging please see:
24 // chrome/test/data/extensions/api_test/activity_log_private/README 27 // chrome/test/data/extensions/api_test/activity_log_private/README
25 28
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 ASSERT_TRUE(web_contents); 95 ASSERT_TRUE(web_contents);
93 96
94 content::WindowedNotificationObserver page_observer( 97 content::WindowedNotificationObserver page_observer(
95 content::NOTIFICATION_LOAD_STOP, 98 content::NOTIFICATION_LOAD_STOP,
96 content::NotificationService::AllSources()); 99 content::NotificationService::AllSources());
97 100
98 GURL url(base::StringPrintf( 101 GURL url(base::StringPrintf(
99 "http://www.google.com.bo:%d/test.html", 102 "http://www.google.com.bo:%d/test.html",
100 port)); 103 port));
101 104
105 if (!prerender_manager->cookie_store_loaded()) {
106 prerender_manager->set_on_cookie_store_loaded_cb(
107 base::Bind(
108 &base::MessageLoop::Quit,
109 base::Unretained(base::MessageLoop::current())));
110 base::MessageLoop::current()->Run();
111 }
112
102 const gfx::Size kSize(640, 480); 113 const gfx::Size kSize(640, 480);
103 scoped_ptr<prerender::PrerenderHandle> prerender_handle( 114 scoped_ptr<prerender::PrerenderHandle> prerender_handle(
104 prerender_manager->AddPrerenderFromLocalPredictor( 115 prerender_manager->AddPrerenderFromLocalPredictor(
105 url, 116 url,
106 web_contents->GetController().GetDefaultSessionStorageNamespace(), 117 web_contents->GetController().GetDefaultSessionStorageNamespace(),
107 kSize)); 118 kSize));
108 119
109 page_observer.Wait(); 120 page_observer.Wait();
110 121
111 activity_log->GetFilteredActions( 122 activity_log->GetFilteredActions(
112 ext->id(), 123 ext->id(),
113 Action::ACTION_ANY, 124 Action::ACTION_ANY,
114 "", 125 "",
115 "", 126 "",
116 "", 127 "",
117 -1, 128 -1,
118 base::Bind( 129 base::Bind(
119 ActivityLogPrerenderTest::Prerender_Arguments, ext->id(), port)); 130 ActivityLogPrerenderTest::Prerender_Arguments, ext->id(), port));
120 131
121 // Allow invocation of Prerender_Arguments 132 // Allow invocation of Prerender_Arguments
122 base::MessageLoop::current()->Run(); 133 base::MessageLoop::current()->Run();
123 } 134 }
124 135
125 } // namespace extensions 136 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698