chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h - Issue 2333113002: Rename DesktopEngagement* to DesktopSessionDuration*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h

Issue 2333113002: Rename DesktopEngagement* to DesktopSessionDuration*. (Closed)

Patch Set: Change name Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/desktop_session_duration/audible_contents_tracker.h ('K') | « chrome/browser/metrics/desktop_session_duration/audible_contents_tracker_browsertest.cc ('k') | chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc » ('j') | chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h

diff --git a/chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.h b/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h

similarity index 79%

rename from chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.h

rename to chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h

index 8677b432cdfa13c55448b71246d6eff100db56cc..7cf00d26eab5bc28c3392404a7efc4217a1fd00b 100644

--- a/chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.h

+++ b/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h

@@ -2,14 +2,13 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#ifndef CHROME_BROWSER_METRICS_DESKTOP_ENGAGEMENT_CHROME_VISIBILITY_OBSERVER_H_

-#define CHROME_BROWSER_METRICS_DESKTOP_ENGAGEMENT_CHROME_VISIBILITY_OBSERVER_H_

+#ifndef CHROME_BROWSER_METRICS_DESKTOP_SESSION_DURATION_CHROME_VISIBILITY_OBSERVER_H_

+#define CHROME_BROWSER_METRICS_DESKTOP_SESSION_DURATION_CHROME_VISIBILITY_OBSERVER_H_

#include "base/memory/weak_ptr.h"

#include "chrome/browser/ui/browser_list_observer.h"

namespace metrics {

// Observer for tracking browser visibility events.

class ChromeVisibilityObserver : public chrome::BrowserListObserver {

public:

@@ -17,8 +16,8 @@ class ChromeVisibilityObserver : public chrome::BrowserListObserver {

~ChromeVisibilityObserver() override;

protected:

- // Notifies |DesktopEngagementService| of visibility changes. Overridden by

- // tests.

+ // Notifies |DesktopSessionDurationTracker| of visibility changes. Overridden

+ // by tests.

virtual void SendVisibilityChangeEvent(bool active);

private:

@@ -46,4 +45,4 @@ class ChromeVisibilityObserver : public chrome::BrowserListObserver {

} // namespace metrics

-#endif // CHROME_BROWSER_METRICS_DESKTOP_ENGAGEMENT_CHROME_VISIBILITY_OBSERVER_H_

+#endif // CHROME_BROWSER_METRICS_DESKTOP_SESSION_DURATION_CHROME_VISIBILITY_OBSERVER_H_