chrome/browser/metrics/desktop_session_duration/audible_contents_tracker.h - Issue 2333113002: Rename DesktopEngagement* to DesktopSessionDuration*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/desktop_session_duration/audible_contents_tracker.h

Issue 2333113002: Rename DesktopEngagement* to DesktopSessionDuration*. (Closed)

Patch Set: Change name Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/desktop_engagement/desktop_engagement_service_unittest.cc ('k') | chrome/browser/metrics/desktop_session_duration/audible_contents_tracker.cc » ('j') | chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/desktop_session_duration/audible_contents_tracker.h

diff --git a/chrome/browser/metrics/desktop_engagement/audible_contents_tracker.h b/chrome/browser/metrics/desktop_session_duration/audible_contents_tracker.h

similarity index 85%

rename from chrome/browser/metrics/desktop_engagement/audible_contents_tracker.h

rename to chrome/browser/metrics/desktop_session_duration/audible_contents_tracker.h

index cc3e515e7b6bb1b5ccb95d7ab19ce58c9d2e8aad..0b37c665fc66fadb381fc295edb3801afb299005 100644

--- a/chrome/browser/metrics/desktop_engagement/audible_contents_tracker.h

+++ b/chrome/browser/metrics/desktop_session_duration/audible_contents_tracker.h

@@ -2,8 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#ifndef CHROME_BROWSER_METRICS_DESKTOP_ENGAGEMENT_AUDIBLE_CONTENTS_TRACKER_H_

-#define CHROME_BROWSER_METRICS_DESKTOP_ENGAGEMENT_AUDIBLE_CONTENTS_TRACKER_H_

+#ifndef CHROME_BROWSER_METRICS_DESKTOP_SESSION_DURATION_AUDIBLE_CONTENTS_TRACKER_H_

+#define CHROME_BROWSER_METRICS_DESKTOP_SESSION_DURATION_AUDIBLE_CONTENTS_TRACKER_H_

#include <set>

@@ -18,8 +18,8 @@ class AudibleContentsTracker : public chrome::BrowserListObserver,

public TabStripModelObserver {

public:

// Interface for an observer of the AudibleContentsTracker. The only client

- // of this class is the DesktopEngagementService, but an observer interface

- // has been created for ease of testing.

+ // of this class is the DesktopSessionDurationTracker, but an observer

+ // interface has been created for ease of testing.

class Observer {

sky 2016/09/15 03:04:05 for a later patch: Style guide says observers shou

public:

Observer() {}

@@ -73,4 +73,4 @@ class AudibleContentsTracker : public chrome::BrowserListObserver,

} // namespace metrics

-#endif // CHROME_BROWSER_METRICS_DESKTOP_ENGAGEMENT_AUDIBLE_CONTENTS_TRACKER_H_

+#endif // CHROME_BROWSER_METRICS_DESKTOP_SESSION_DURATION_AUDIBLE_CONTENTS_TRACKER_H_