Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7322)

Unified Diff: chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc

Issue 2333113002: Rename DesktopEngagement* to DesktopSessionDuration*. (Closed)
Patch Set: Change name Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc
diff --git a/chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.cc b/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc
similarity index 87%
rename from chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.cc
rename to chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc
index fcd72072ec2c82120767b5f5fe32cb5d8c54cdd1..8cce013524d4746bb2c7c5af59728c4c37ce1c31 100644
--- a/chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.cc
+++ b/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc
@@ -2,12 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.h"
+#include "chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.h"
#include "base/memory/singleton.h"
#include "base/strings/string_number_conversions.h"
#include "base/threading/thread_task_runner_handle.h"
-#include "chrome/browser/metrics/desktop_engagement/desktop_engagement_service.h"
+#include "chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
#include "components/variations/variations_associated_data.h"
@@ -24,7 +24,7 @@ ChromeVisibilityObserver::~ChromeVisibilityObserver() {
}
void ChromeVisibilityObserver::SendVisibilityChangeEvent(bool active) {
- DesktopEngagementService::Get()->OnVisibilityChanged(active);
+ DesktopSessionDurationTracker::Get()->OnVisibilityChanged(active);
}
void ChromeVisibilityObserver::CancelVisibilityChange() {
@@ -60,7 +60,7 @@ void ChromeVisibilityObserver::InitVisibilityGapTimeout() {
int timeout_seconds = kDefaultVisibilityGapTimeout;
std::string param_value = variations::GetVariationParamValue(
- "DesktopEngagement", "visibility_gap_timeout");
+ "DesktopSessionDuration", "visibility_gap_timeout");
sky 2016/09/15 03:04:05 Who keys off this string and does it need to be up
dominickn 2016/09/15 03:13:46 Already asked and clarified this question in ps1:
if (!param_value.empty())
base::StringToInt(param_value, &timeout_seconds);

Powered by Google App Engine
This is Rietveld 408576698