Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2332473003: SkPDF: SkShaper_primitive uses new textblob API (Closed)

Created:
4 years, 3 months ago by hal.canary
Modified:
4 years, 3 months ago
Reviewers:
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: SkShaper_primitive uses new textblob API This will enable me to test the new API in unit tests without depending on HarfBuzz (after https://crrev.com/2322403002 lands). TBR= BUG=skia:5434 Committed: https://skia.googlesource.com/skia/+/3eee9d941e773d576917d4a5e89fd4b2b8f53253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M BUILD.gn View 2 chunks +11 lines, -1 line 0 comments Download
M tools/SkShaper_primitive.cpp View 2 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332473003/1
4 years, 3 months ago (2016-09-10 13:36:31 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 14:01:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3eee9d941e773d576917d4a5e89fd4b2b8f53253

Powered by Google App Engine
This is Rietveld 408576698