Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2332403003: Use api.chromium.compile() in client.nacl.sdk.recipe_autogen.py (Closed)

Created:
4 years, 3 months ago by Sam Clegg
Modified:
4 years, 3 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Use api.chromium.compile() in client.nacl.sdk.recipe_autogen.py Rather than handrolling a call to compile.py using api.python. This ensues that goma is setup correctly. BUG=646185 Committed: https://chromium.googlesource.com/chromium/tools/build/+/0fc6b2e65ce4651c7b70239c4b7cc36489fa0c97

Patch Set 1 #

Messages

Total messages: 10 (6 generated)
Sam Clegg
4 years, 3 months ago (2016-09-13 21:08:13 UTC) #2
bradn
lgtm
4 years, 3 months ago (2016-09-13 21:44:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332403003/1
4 years, 3 months ago (2016-09-13 21:44:33 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 21:49:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/0fc6b2e65ce4651c7b70...

Powered by Google App Engine
This is Rietveld 408576698