Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py

Issue 2332403003: Use api.chromium.compile() in client.nacl.sdk.recipe_autogen.py (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_asan_multi.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py
diff --git a/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py b/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py
index 8ebbf8b50ec168a12e448c63d53c2e635a4c1fbe..1872668fdfa97f74bdb9b5aae504f4858dd2c549 100644
--- a/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py
+++ b/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py
@@ -79,11 +79,8 @@ def linux_sdk_multi_steps(api):
# cleanup_temp step
api.chromium.cleanup_temp()
- # compile.py step
- args = ['--target', 'Release', '--compiler=goma', 'chrome']
- api.python("compile",
- api.path["build"].join("scripts", "slave", "compile.py"),
- args=args)
+ # compile step
+ api.chromium.compile(['chrome'])
# annotated_steps step
api.python(
@@ -169,12 +166,9 @@ def mac_sdk_multi_steps(api):
# cleanup_temp step
api.chromium.cleanup_temp()
- # compile.py step
- args = ['--target', 'Release', '--build-tool=ninja',
- '--compiler=goma-clang', '--', 'chrome']
- api.python("compile",
- api.path["build"].join("scripts", "slave", "compile.py"),
- args=args)
+ # compile step
+ api.chromium.compile(['chrome'])
+
# annotated_steps step
api.python(
"annotated_steps",
@@ -259,11 +253,9 @@ def windows_sdk_multi_steps(api):
# cleanup_temp step
api.chromium.cleanup_temp()
- # compile.py step
- args = ['--target', 'Release', '--compiler=goma', 'chrome']
- api.python("compile",
- api.path["build"].join("scripts", "slave", "compile.py"),
- args=args)
+ # compile step
+ api.chromium.compile(['chrome'])
+
# annotated_steps step
api.python(
"annotated_steps",
@@ -323,11 +315,9 @@ def linux_sdk_multirel_steps(api):
# cleanup_temp step
api.chromium.cleanup_temp()
- # compile.py step
- args = ['--target', 'Release', '--compiler=goma', 'chrome']
- api.python("compile",
- api.path["build"].join("scripts", "slave", "compile.py"),
- args=args)
+ # compile step
+ api.chromium.compile(['chrome'])
+
# annotated_steps step
api.python(
"annotated_steps",
@@ -389,11 +379,9 @@ def windows_sdk_multirel_steps(api):
# cleanup_temp step
api.chromium.cleanup_temp()
- # compile.py step
- args = ['--target', 'Release', '--compiler=goma', 'chrome',]
- api.python("compile",
- api.path["build"].join("scripts", "slave", "compile.py"),
- args=args)
+ # compile step
+ api.chromium.compile(['chrome'])
+
# annotated_steps step
api.python(
"annotated_steps",
@@ -454,12 +442,9 @@ def mac_sdk_multirel_steps(api):
# cleanup_temp step
api.chromium.cleanup_temp()
- # compile.py step
- args = ['--target', 'Release', '--build-tool=ninja',
- '--compiler=goma-clang', '--', 'chrome']
- api.python("compile",
- api.path["build"].join("scripts", "slave", "compile.py"),
- args=args)
+ # compile step
+ api.chromium.compile(['chrome'])
+
# annotated_steps step
api.python(
"annotated_steps",
« no previous file with comments | « no previous file | scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_asan_multi.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698