scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multi.json - Issue 2332403003: Use api.chromium.compile() in client.nacl.sdk.recipe_autogen.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multi.json

Issue 2332403003: Use api.chromium.compile() in client.nacl.sdk.recipe_autogen.py (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multirel.json ('k') | scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multirel.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multi.json

diff --git a/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multi.json b/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multi.json

index 7388d4ad99856b8e96d2effae976d787cc975048..0c1290f804ae320a71b1e5aca4fc96603e389323 100644

--- a/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multi.json

+++ b/scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multi.json

@@ -209,13 +209,45 @@

"cmd": [

"python",

"-u",

- "[BUILD]/scripts/slave/compile.py",

+ "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",

+ "--show-path",

+ "python",

+ "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",

+ "--gsutil-py-path",

+ "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",

+ "--ninja-path",

+ "RECIPE_PACKAGE_REPO[depot_tools]/ninja",

"--target",

"Release",

- "--compiler=goma",

+ "--src-dir",

+ "[SLAVE_BUILD]/src",

+ "--goma-cache-dir",

+ "[GOMA_CACHE]",

+ "--buildbot-buildername",

+ "windows-sdk-multi",

+ "--buildbot-mastername",

+ "client.nacl.sdk",

+ "--buildbot-slavename",

+ "TestSlave",

+ "--compiler",

+ "goma",

+ "--goma-jsonstatus",

+ "/path/to/tmp/json",

+ "--goma-service-account-json-file",

+ "/creds/service_accounts/service-account-goma-client.json",

+ "--goma-dir",

+ "[CACHE]/cipd/goma",

+ "--",

"chrome"

- "name": "compile"

+ "env": {

+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

+ },

+ "name": "compile",

+ "~followup_annotations": [

+ "@@@STEP_LOG_LINE@json.output (invalid)@null@@@",

+ "@@@STEP_LOG_END@json.output (invalid)@@@"

+ ]

{

"allow_subannotations": true,