Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2332333005: [Cronet] Change package_ios.py to generate dSYM for debug builds. (Closed)

Created:
4 years, 3 months ago by mef
Modified:
4 years, 3 months ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Change package_ios.py to generate dSYM for debug builds. Committed: https://crrev.com/40b132906467ae908c89a7519179dcdd0e7019cb Cr-Commit-Position: refs/heads/master@{#418877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M components/cronet/tools/package_ios.py View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mef
4 years, 3 months ago (2016-09-14 21:13:07 UTC) #3
kapishnikov
lgtm
4 years, 3 months ago (2016-09-15 04:01:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332333005/1
4 years, 3 months ago (2016-09-15 14:47:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 15:57:05 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 17:01:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40b132906467ae908c89a7519179dcdd0e7019cb
Cr-Commit-Position: refs/heads/master@{#418877}

Powered by Google App Engine
This is Rietveld 408576698