Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Side by Side Diff: components/cronet/tools/package_ios.py

Issue 2332333005: [Cronet] Change package_ios.py to generate dSYM for debug builds. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright 2016 The Chromium Authors. All rights reserved. 2 # Copyright 2016 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 package_ios.py - Build and Package Release and Rebug fat libraries for iOS. 7 package_ios.py - Build and Package Release and Rebug fat libraries for iOS.
8 """ 8 """
9 9
10 import argparse 10 import argparse
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 os.path.join(out_dir, 'Headers')) 84 os.path.join(out_dir, 'Headers'))
85 85
86 86
87 def package_ios_framework_using_gn(out_dir='out/Framework', extra_options=''): 87 def package_ios_framework_using_gn(out_dir='out/Framework', extra_options=''):
88 print 'Building Cronet Dynamic Framework using gn...' 88 print 'Building Cronet Dynamic Framework using gn...'
89 89
90 # Package all builds in the output directory 90 # Package all builds in the output directory
91 os.makedirs(out_dir) 91 os.makedirs(out_dir)
92 build_dir = '' 92 build_dir = ''
93 for (build_config, gn_extra_args) in [('Debug', 'is_debug=true'), 93 for (build_config, gn_extra_args) in [('Debug', 'is_debug=true'),
94 ('Release', 'is_debug=false enable_dsyms=true enable_stripping=true')]: 94 ('Release', 'is_debug=false enable_stripping=true')]:
95 for (target_device, target_cpu, additional_cpu) in [('os', 'arm', 'arm64'), 95 for (target_device, target_cpu, additional_cpu) in [('os', 'arm', 'arm64'),
96 ('simulator', 'x86', 'x64')]: 96 ('simulator', 'x86', 'x64')]:
97 target_dir = '%s-iphone%s' % (build_config, target_device) 97 target_dir = '%s-iphone%s' % (build_config, target_device)
98 build_dir = os.path.join("out", target_dir) 98 build_dir = os.path.join("out", target_dir)
99 gn_args = 'target_os="ios" enable_websockets=false ' \ 99 gn_args = 'target_os="ios" enable_websockets=false ' \
100 'is_cronet_build=true is_component_build=false ' \
100 'disable_file_support=true disable_ftp_support=true ' \ 101 'disable_file_support=true disable_ftp_support=true ' \
101 'use_platform_icu_alternatives=true ' \ 102 'use_platform_icu_alternatives=true ' \
102 'disable_brotli_filter=true ' \ 103 'disable_brotli_filter=true enable_dsyms=true ' \
103 'target_cpu="%s" additional_target_cpus = ["%s"] %s' % \ 104 'target_cpu="%s" additional_target_cpus = ["%s"] %s' % \
104 (target_cpu, additional_cpu, gn_extra_args) 105 (target_cpu, additional_cpu, gn_extra_args)
105 106
106 print 'Generating Ninja ' + gn_args 107 print 'Generating Ninja ' + gn_args
107 gn_result = run('gn gen %s --args=\'%s\'' % (build_dir, gn_args)) 108 gn_result = run('gn gen %s --args=\'%s\'' % (build_dir, gn_args))
108 if gn_result != 0: 109 if gn_result != 0:
109 return gn_result 110 return gn_result
110 111
111 print 'Building ' + build_dir 112 print 'Building ' + build_dir
112 build_result = run('ninja -C %s cronet_package' % build_dir, 113 build_result = run('ninja -C %s cronet_package' % build_dir,
113 extra_options) 114 extra_options)
114 if build_result != 0: 115 if build_result != 0:
115 return build_result 116 return build_result
116 117
117 # Copy framework. 118 # Copy framework.
118 shutil.copytree(os.path.join(build_dir, 'Cronet.framework'), 119 shutil.copytree(os.path.join(build_dir, 'Cronet.framework'),
119 os.path.join(out_dir, target_dir, 'Cronet.framework')) 120 os.path.join(out_dir, target_dir, 'Cronet.framework'))
120 # Copy symbols from release binaries. 121 # Copy symbols.
121 if 'Release' in build_config: 122 shutil.copytree(os.path.join(build_dir, 'Cronet.dSYM'),
122 shutil.copytree(os.path.join(build_dir, 'Cronet.dSYM'), 123 os.path.join(out_dir, target_dir, 'Cronet.framework.dSYM'))
123 os.path.join(out_dir, target_dir, 'Cronet.framework.dSYM'))
124 124
125 # Copy common files from last built package. 125 # Copy common files from last built package.
126 package_dir = os.path.join(build_dir, 'cronet') 126 package_dir = os.path.join(build_dir, 'cronet')
127 shutil.copy2(os.path.join(package_dir, 'AUTHORS'), out_dir) 127 shutil.copy2(os.path.join(package_dir, 'AUTHORS'), out_dir)
128 shutil.copy2(os.path.join(package_dir, 'LICENSE'), out_dir) 128 shutil.copy2(os.path.join(package_dir, 'LICENSE'), out_dir)
129 shutil.copy2(os.path.join(package_dir, 'VERSION'), out_dir) 129 shutil.copy2(os.path.join(package_dir, 'VERSION'), out_dir)
130 # Copy the headers. 130 # Copy the headers.
131 shutil.copytree(os.path.join(build_dir, 131 shutil.copytree(os.path.join(build_dir,
132 'Cronet.framework', 'Headers'), 132 'Cronet.framework', 'Headers'),
133 os.path.join(out_dir, 'Headers')) 133 os.path.join(out_dir, 'Headers'))
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 190
191 if options.gn: 191 if options.gn:
192 return package_ios_framework_using_gn(out_dir, extra_options_list) 192 return package_ios_framework_using_gn(out_dir, extra_options_list)
193 193
194 return package_ios(out_dir, "out/Release", "opt") or \ 194 return package_ios(out_dir, "out/Release", "opt") or \
195 package_ios(out_dir, "out/Debug", "dbg") 195 package_ios(out_dir, "out/Debug", "dbg")
196 196
197 197
198 if __name__ == '__main__': 198 if __name__ == '__main__':
199 sys.exit(main()) 199 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698