Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: components/cronet/tools/package_ios.py

Issue 2332333005: [Cronet] Change package_ios.py to generate dSYM for debug builds. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/tools/package_ios.py
diff --git a/components/cronet/tools/package_ios.py b/components/cronet/tools/package_ios.py
index 256b1c0a20fb1fe48ea250e5f1ec93e074b4bf36..829dec2edcfc792b431a6779ec1eb068da346d42 100755
--- a/components/cronet/tools/package_ios.py
+++ b/components/cronet/tools/package_ios.py
@@ -91,15 +91,16 @@ def package_ios_framework_using_gn(out_dir='out/Framework', extra_options=''):
os.makedirs(out_dir)
build_dir = ''
for (build_config, gn_extra_args) in [('Debug', 'is_debug=true'),
- ('Release', 'is_debug=false enable_dsyms=true enable_stripping=true')]:
+ ('Release', 'is_debug=false enable_stripping=true')]:
for (target_device, target_cpu, additional_cpu) in [('os', 'arm', 'arm64'),
('simulator', 'x86', 'x64')]:
target_dir = '%s-iphone%s' % (build_config, target_device)
build_dir = os.path.join("out", target_dir)
gn_args = 'target_os="ios" enable_websockets=false ' \
+ 'is_cronet_build=true is_component_build=false ' \
'disable_file_support=true disable_ftp_support=true ' \
'use_platform_icu_alternatives=true ' \
- 'disable_brotli_filter=true ' \
+ 'disable_brotli_filter=true enable_dsyms=true ' \
'target_cpu="%s" additional_target_cpus = ["%s"] %s' % \
(target_cpu, additional_cpu, gn_extra_args)
@@ -117,10 +118,9 @@ def package_ios_framework_using_gn(out_dir='out/Framework', extra_options=''):
# Copy framework.
shutil.copytree(os.path.join(build_dir, 'Cronet.framework'),
os.path.join(out_dir, target_dir, 'Cronet.framework'))
- # Copy symbols from release binaries.
- if 'Release' in build_config:
- shutil.copytree(os.path.join(build_dir, 'Cronet.dSYM'),
- os.path.join(out_dir, target_dir, 'Cronet.framework.dSYM'))
+ # Copy symbols.
+ shutil.copytree(os.path.join(build_dir, 'Cronet.dSYM'),
+ os.path.join(out_dir, target_dir, 'Cronet.framework.dSYM'))
# Copy common files from last built package.
package_dir = os.path.join(build_dir, 'cronet')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698