[sensors] Ambient light sensor bindings implementation
This patch implements AmbientLightSensor [1] blink bindings and adds
LayoutTest helpers for testing sensors that are based on Generic Sensor API.
Following layout tests added to test new functionality:
IDL tests.
- third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensor.html
- third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensorReading.html
AmbientLightSensor tests.
- third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TkfdVqYAYiE/xLGN2b1-AAAJ
[1] ED specification for Ambient Light Sensor http://w3c.github.io/ambient-light/
BUG=606766
Committed: https://crrev.com/c457d06894e8f01b24ae83750203fb5d8819c560
Cr-Commit-Position: refs/heads/master@{#419438}
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/68300) mac_chromium_rel_ng on ...
4 years, 3 months ago
(2016-09-13 11:19:52 UTC)
#10
Description was changed from ========== [sensors] Ambient light sensor bindings implementation This patch implements AmbientLightSensor ...
4 years, 3 months ago
(2016-09-15 15:00:15 UTC)
#14
Description was changed from
==========
[sensors] Ambient light sensor bindings implementation
This patch implements AmbientLightSensor [1] blink bindings and adds
LayoutTest helpers for testing sensors that are based on Generic Sensor API.
Following layout tests added to test new functionality:
IDL tests.
- third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensor.html
- third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensorReading.html
AmbientLightSensor tests.
- third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
[1] ED specification for Ambient Light Sensor
http://w3c.github.io/ambient-light/
BUG=606766
==========
to
==========
[sensors] Ambient light sensor bindings implementation
This patch implements AmbientLightSensor [1] blink bindings and adds
LayoutTest helpers for testing sensors that are based on Generic Sensor API.
Following layout tests added to test new functionality:
IDL tests.
- third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensor.html
- third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensorReading.html
AmbientLightSensor tests.
- third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TkfdVqYAYiE/xL...
[1] ED specification for Ambient Light Sensor
http://w3c.github.io/ambient-light/
BUG=606766
==========
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago
(2016-09-15 15:49:00 UTC)
#15
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/296999)
4 years, 3 months ago
(2016-09-15 15:49:01 UTC)
#16
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/258681)
4 years, 3 months ago
(2016-09-16 07:42:08 UTC)
#21
timvolodine@ do you have any comments for this CL?
4 years, 3 months ago
(2016-09-16 09:58:03 UTC)
#22
timvolodine@ do you have any comments for this CL?
shalamov
On 2016/09/16 09:58:03, shalamov wrote: > timvolodine@ do you have any comments for this CL? ...
4 years, 3 months ago
(2016-09-19 07:15:57 UTC)
#23
On 2016/09/16 09:58:03, shalamov wrote:
> timvolodine@ do you have any comments for this CL?
timvolodine@ I've fixed comments from Mikhail, Riju and Haraken, if you have any
comments, I will fix those in follow-up patches.
shalamov
The CQ bit was checked by alexander.shalamov@intel.com
4 years, 3 months ago
(2016-09-19 07:16:03 UTC)
#24
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/32651)
4 years, 3 months ago
(2016-09-19 08:37:17 UTC)
#28
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/32665)
4 years, 3 months ago
(2016-09-19 10:31:34 UTC)
#32
Description was changed from ========== [sensors] Ambient light sensor bindings implementation This patch implements AmbientLightSensor ...
4 years, 3 months ago
(2016-09-19 12:33:05 UTC)
#35
Message was sent while issue was closed.
Description was changed from
==========
[sensors] Ambient light sensor bindings implementation
This patch implements AmbientLightSensor [1] blink bindings and adds
LayoutTest helpers for testing sensors that are based on Generic Sensor API.
Following layout tests added to test new functionality:
IDL tests.
- third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensor.html
- third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensorReading.html
AmbientLightSensor tests.
- third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TkfdVqYAYiE/xL...
[1] ED specification for Ambient Light Sensor
http://w3c.github.io/ambient-light/
BUG=606766
==========
to
==========
[sensors] Ambient light sensor bindings implementation
This patch implements AmbientLightSensor [1] blink bindings and adds
LayoutTest helpers for testing sensors that are based on Generic Sensor API.
Following layout tests added to test new functionality:
IDL tests.
- third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensor.html
- third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensorReading.html
AmbientLightSensor tests.
- third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TkfdVqYAYiE/xL...
[1] ED specification for Ambient Light Sensor
http://w3c.github.io/ambient-light/
BUG=606766
==========
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago
(2016-09-19 12:33:06 UTC)
#36
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
commit-bot: I haz the power
Description was changed from ========== [sensors] Ambient light sensor bindings implementation This patch implements AmbientLightSensor ...
4 years, 3 months ago
(2016-09-19 12:34:57 UTC)
#37
Message was sent while issue was closed.
Description was changed from
==========
[sensors] Ambient light sensor bindings implementation
This patch implements AmbientLightSensor [1] blink bindings and adds
LayoutTest helpers for testing sensors that are based on Generic Sensor API.
Following layout tests added to test new functionality:
IDL tests.
- third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensor.html
- third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensorReading.html
AmbientLightSensor tests.
- third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TkfdVqYAYiE/xL...
[1] ED specification for Ambient Light Sensor
http://w3c.github.io/ambient-light/
BUG=606766
==========
to
==========
[sensors] Ambient light sensor bindings implementation
This patch implements AmbientLightSensor [1] blink bindings and adds
LayoutTest helpers for testing sensors that are based on Generic Sensor API.
Following layout tests added to test new functionality:
IDL tests.
- third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensor.html
- third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensorReading.html
AmbientLightSensor tests.
- third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TkfdVqYAYiE/xL...
[1] ED specification for Ambient Light Sensor
http://w3c.github.io/ambient-light/
BUG=606766
Committed: https://crrev.com/c457d06894e8f01b24ae83750203fb5d8819c560
Cr-Commit-Position: refs/heads/master@{#419438}
==========
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/c457d06894e8f01b24ae83750203fb5d8819c560 Cr-Commit-Position: refs/heads/master@{#419438}
4 years, 3 months ago
(2016-09-19 12:34:58 UTC)
#38
looks good thanks! impressive 'mocking' :). just some thoughts, for this or follow-up patches https://codereview.chromium.org/2332323002/diff/80001/third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html ...
4 years, 3 months ago
(2016-09-19 16:37:32 UTC)
#40
Issue 2332323002: [sensors] Ambient light sensor bindings implementation
(Closed)
Created 4 years, 3 months ago by shalamov
Modified 4 years, 3 months ago
Reviewers: jochen (gone - plz use gerrit), haraken, Mikhail, riju_, timvolodine
Base URL:
Comments: 13