third_party/WebKit/Source/modules/sensor/AmbientLightSensor.idl - Issue 2332323002: [sensors] Ambient light sensor bindings implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/sensor/AmbientLightSensor.idl

Issue 2332323002: [sensors] Ambient light sensor bindings implementation (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Specification at:

	6 // https://w3c.github.io/ambient-light/#ambient-light-sensor-interface

	7

	8 [

	9 RuntimeEnabled=Sensor,

	10 DependentLifetime,
	haraken 2016/09/13 09:45:04 Why do you need [DependentLifetime]? Why do you need [DependentLifetime]? shalamov 2016/09/13 10:34:17 I think I can remove it, since the base class alre Show quoted text On 2016/09/13 09:45:04, haraken wrote: > > Why do you need [DependentLifetime]? I think I can remove it, since the base class already has ActiveScriptWrappable and DependentLifetime attributes. https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/sensor...
	11 Constructor(optional SensorOptions sensorOptions),

	12 ConstructorCallWith=ExecutionContext,

	13 ] interface AmbientLightSensor : Sensor {

	14 readonly attribute AmbientLightSensorReading? reading;

	15 };

OLD	NEW