[inspector] fixed all deprecated calls

[inspector] fixed all deprecated calls

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/072c6943367828657e36f11bbfbbbd95a54d3431
Cr-Commit-Position: refs/heads/master@{#39506}

[kozy, 2016-09-13 01:18:17]

please take a look!

[alph, 2016-09-13 01:46:23]

https://codereview.chromium.org/2332243002/diff/1/src/inspector/V8InspectorIm...
File src/inspector/V8InspectorImpl.cpp (right):

https://codereview.chromium.org/2332243002/diff/1/src/inspector/V8InspectorIm...
src/inspector/V8InspectorImpl.cpp:274: v8::CpuProfiler* cpuProfiler =
v8::CpuProfiler::New(m_isolate);
Please take the CpuProfiler out of V8ProfilerAgent instead

[kozy, 2016-09-13 20:42:52]

all done. please take another look!

https://codereview.chromium.org/2332243002/diff/1/src/inspector/V8InspectorIm...
File src/inspector/V8InspectorImpl.cpp (right):

https://codereview.chromium.org/2332243002/diff/1/src/inspector/V8InspectorIm...
src/inspector/V8InspectorImpl.cpp:274: v8::CpuProfiler* cpuProfiler =
v8::CpuProfiler::New(m_isolate);
On 2016/09/13 01:46:23, alph wrote:
> Please take the CpuProfiler out of V8ProfilerAgent instead

Done.

[kozy, 2016-09-15 15:55:56]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 15:56:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 16:17:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 16:17:46]

Dry run: This issue passed the CQ dry run.

[alph, 2016-09-15 17:52:12]

lgtm

https://codereview.chromium.org/2332243002/diff/40001/src/inspector/V8Debugge...
File src/inspector/V8DebuggerScript.cpp (right):

https://codereview.chromium.org/2332243002/diff/40001/src/inspector/V8Debugge...
src/inspector/V8DebuggerScript.cpp:82: .ToLocalChecked());
Consider extracting "Get(context, toV8StringInternalized(isolate,
"name")).ToLocalChecked()" to a helper function.

https://codereview.chromium.org/2332243002/diff/40001/src/inspector/V8StackTr...
File src/inspector/V8StackTraceImpl.cpp (right):

https://codereview.chromium.org/2332243002/diff/40001/src/inspector/V8StackTr...
src/inspector/V8StackTraceImpl.cpp:167: profilerAgent->collectSample();
can it be null?

[kozy, 2016-09-15 20:18:51]

all done

https://codereview.chromium.org/2332243002/diff/40001/src/inspector/V8Debugge...
File src/inspector/V8DebuggerScript.cpp (right):

https://codereview.chromium.org/2332243002/diff/40001/src/inspector/V8Debugge...
src/inspector/V8DebuggerScript.cpp:82: .ToLocalChecked());
On 2016/09/15 17:52:11, alph wrote:
> Consider extracting "Get(context, toV8StringInternalized(isolate,
> "name")).ToLocalChecked()" to a helper function.

Done.

https://codereview.chromium.org/2332243002/diff/40001/src/inspector/V8StackTr...
File src/inspector/V8StackTraceImpl.cpp (right):

https://codereview.chromium.org/2332243002/diff/40001/src/inspector/V8StackTr...
src/inspector/V8StackTraceImpl.cpp:167: profilerAgent->collectSample();
On 2016/09/15 17:52:11, alph wrote:
> can it be null?

Done.

[kozy, 2016-09-15 20:19:50]

kozyatinskiy@chromium.org changed reviewers:
+ jochen@chromium.org

[kozy, 2016-09-15 20:19:50]

Jochen, please take a look. I need owner lgtm for v8.gyp.

[kozy, 2016-09-15 20:20:02]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 20:20:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 21:25:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 21:25:36]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-09-19 14:22:37]

lgtm

[kozy, 2016-09-19 15:44:55]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-09-19 15:44:55]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2332243002/#ps60001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-09-19 15:45:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 16:10:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-19 16:11:29]

Description was changed from

==========
[inspector] fixed all deprecated calls

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] fixed all deprecated calls

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/072c6943367828657e36f11bbfbbbd95a54d3431
Cr-Commit-Position: refs/heads/master@{#39506}
==========

[commit-bot: I haz the power, 2016-09-19 16:11:31]

Patchset 4 (id:??) landed as
https://crrev.com/072c6943367828657e36f11bbfbbbd95a54d3431
Cr-Commit-Position: refs/heads/master@{#39506}