Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: src/inspector/V8InjectedScriptHost.cpp

Issue 2332243002: [inspector] fixed all deprecated calls (Closed)
Patch Set: addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/V8DebuggerScript.cpp ('k') | src/inspector/V8InspectorImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/V8InjectedScriptHost.cpp
diff --git a/src/inspector/V8InjectedScriptHost.cpp b/src/inspector/V8InjectedScriptHost.cpp
index 376a8f58ceea2c17a8a95905dd2dac75ffc029b1..3ccf31e2b4c9b3f2d5291edda11a263f69d8ed62 100644
--- a/src/inspector/V8InjectedScriptHost.cpp
+++ b/src/inspector/V8InjectedScriptHost.cpp
@@ -189,10 +189,13 @@ void V8InjectedScriptHost::bindCallback(
const v8::FunctionCallbackInfo<v8::Value>& info) {
if (info.Length() < 2 || !info[1]->IsString()) return;
InjectedScriptNative* injectedScriptNative =
- InjectedScriptNative::fromInjectedScriptHost(info.Holder());
+ InjectedScriptNative::fromInjectedScriptHost(info.GetIsolate(),
+ info.Holder());
if (!injectedScriptNative) return;
- v8::Local<v8::String> v8groupName = info[1]->ToString(info.GetIsolate());
+ v8::Local<v8::Context> context = info.GetIsolate()->GetCurrentContext();
+ v8::Local<v8::String> v8groupName =
+ info[1]->ToString(context).ToLocalChecked();
String16 groupName = toProtocolStringWithTypeCheck(v8groupName);
int id = injectedScriptNative->bind(info[0], groupName);
info.GetReturnValue().Set(id);
« no previous file with comments | « src/inspector/V8DebuggerScript.cpp ('k') | src/inspector/V8InspectorImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698